Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/init confs #23

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Feat/init confs #23

merged 4 commits into from
Oct 16, 2024

Conversation

WilliGautier
Copy link
Contributor

Update initial conf by:

  • Removing link to demo
  • Fixing local arlas server address
  • Removing link to eo templates

"local": ARLAS(
server=Resource(location="http://localhost/server", headers={"Content-Type": "application/json"}),
server=Resource(location="http://localhost/arlas", headers={"Content-Type": "application/json"}),
persistence=Resource(location="http://localhost/persist", headers={"Content-Type": "application/json"}),
elastic=Resource(location="http://localhost:9200", headers={"Content-Type": "application/json"}),
allow_delete=True
)
},
mappings={
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I remove totally the mappings and models sections or leave it empty to know where to modify it?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it can be interesting to leave it, to tell the user that this option exists

},
models={
"arlas_eo": Resource(location="https://raw.githubusercontent.com/gisaia/ARLAS-EO/master/collection.json")
}
)
Configuration.save(variables["configuration_file"])
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line under:

Warning : no configuration file found, we created an empty one for you

is not totally true as the created configuration contains a local conf. Do we want to change it ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, saying "We created a default one that is compatible with the simple exploration stack" is more accurate

"local": ARLAS(
server=Resource(location="http://localhost/server", headers={"Content-Type": "application/json"}),
server=Resource(location="http://localhost/arlas", headers={"Content-Type": "application/json"}),
persistence=Resource(location="http://localhost/persist", headers={"Content-Type": "application/json"}),
elastic=Resource(location="http://localhost:9200", headers={"Content-Type": "application/json"}),
allow_delete=True
)
},
mappings={

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it can be interesting to leave it, to tell the user that this option exists

},
models={
"arlas_eo": Resource(location="https://raw.githubusercontent.com/gisaia/ARLAS-EO/master/collection.json")
}
)
Configuration.save(variables["configuration_file"])

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, saying "We created a default one that is compatible with the simple exploration stack" is more accurate

@WilliGautier WilliGautier merged commit c143f79 into master Oct 16, 2024
1 check passed
@WilliGautier WilliGautier deleted the feat/init_confs branch October 16, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants