-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/init confs #23
Feat/init confs #23
Conversation
"local": ARLAS( | ||
server=Resource(location="http://localhost/server", headers={"Content-Type": "application/json"}), | ||
server=Resource(location="http://localhost/arlas", headers={"Content-Type": "application/json"}), | ||
persistence=Resource(location="http://localhost/persist", headers={"Content-Type": "application/json"}), | ||
elastic=Resource(location="http://localhost:9200", headers={"Content-Type": "application/json"}), | ||
allow_delete=True | ||
) | ||
}, | ||
mappings={ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I remove totally the mappings
and models
sections or leave it empty to know where to modify it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it can be interesting to leave it, to tell the user that this option exists
}, | ||
models={ | ||
"arlas_eo": Resource(location="https://raw.githubusercontent.com/gisaia/ARLAS-EO/master/collection.json") | ||
} | ||
) | ||
Configuration.save(variables["configuration_file"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The line under:
Warning : no configuration file found, we created an empty one for you
is not totally true as the created configuration contains a local conf. Do we want to change it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, saying "We created a default one that is compatible with the simple exploration stack" is more accurate
"local": ARLAS( | ||
server=Resource(location="http://localhost/server", headers={"Content-Type": "application/json"}), | ||
server=Resource(location="http://localhost/arlas", headers={"Content-Type": "application/json"}), | ||
persistence=Resource(location="http://localhost/persist", headers={"Content-Type": "application/json"}), | ||
elastic=Resource(location="http://localhost:9200", headers={"Content-Type": "application/json"}), | ||
allow_delete=True | ||
) | ||
}, | ||
mappings={ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it can be interesting to leave it, to tell the user that this option exists
}, | ||
models={ | ||
"arlas_eo": Resource(location="https://raw.githubusercontent.com/gisaia/ARLAS-EO/master/collection.json") | ||
} | ||
) | ||
Configuration.save(variables["configuration_file"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, saying "We created a default one that is compatible with the simple exploration stack" is more accurate
Update initial conf by: