update to arlas 26.0.2, add set_alias and fix set collection name #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylvaingaudan
requested review from
mbarbet,
MohamedHamouGisaia and
QuCMGisaia
mbarbet
approved these changes
Sep 27, 2024
QuCMGisaia
approved these changes
Sep 27, 2024
arlas/cli/collections.py
Outdated
| ): | ||
| config = variables["arlas"] | ||
| fields = Service.set_collection_field_display_name(config, collection, field_path, display_name) | ||
| tab = PrettyTable(fields[0], align="l") |
There was a problem hiding this comment.
I feel like this code (l111-l113) is often repeated and there always is the add_rows. is it not possible to directly do everything by giving all the fields ?
| ELASTIC_VERSION=docker.elastic.co/elasticsearch/elasticsearch:8.11.1 | ||
| ARLAS_PERSISTENCE_SERVER_VERSION=gisaia/arlas-persistence-server:24.0.5 | ||
| ARLAS_PERSISTENCE_SERVER_VERSION=gisaia/arlas-persistence-server:26.0.0 |
There was a problem hiding this comment.
I think there is a persistence 26.0.1
There was a problem hiding this comment.
I do not see it:
https://github.com/gisaia/ARLAS-persistence/tags
There was a problem hiding this comment.
then there is non and i thought wrong !
QuCMGisaia
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set_aliasto set a display name for a field path, add testsnameoperation to set the display name of a collection, add tests26.0.2Side changes:
tests.sh