Feat/disabledrivers #223
Merged
Feat/disabledrivers #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylvaingaudan
force-pushed
the
feat/disabledrivers
branch
from
cbb81ce to
d62ae9d
Compare
sylvaingaudan
requested review from
mbarbet,
QuCMGisaia and
MohamedHamouGisaia
QuCMGisaia
approved these changes
Jan 6, 2025
| return list(map(lambda p: p.name, DriverManager.drivers[process])) | ||
|
|
||
| @staticmethod | ||
| def solve(process: str, ressource, include_drivers: list[str] = [], exclude_drivers: list[str] = []) -> AbstractDriver: |
There was a problem hiding this comment.
does resource have a type? Should be with only one s by the way
There was a problem hiding this comment.
No, it does not have a type: it depends on the process: ingest->url, download->item
| @@ -88,6 +83,8 @@ def init(configuration: dict): | |||
| raise DriverException("Invalid configuration for download drivers ({})".format(configuration)) | |||
| AprocProcess.input_model = InputDownloadProcess | |||
| Notifications.init() | |||
| description.inputs.get("include_drivers").schema_.items.enum = DriverManager.driver_names(summary.id) | |||
There was a problem hiding this comment.
I don't understand why you have to access to the properties this way, and not by just doing description.inputs.include_drivers
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Side change: