Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:enable aggregation for geaoshape field #1024

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

feat:enable aggregation for geaoshape field #1024

wants to merge 2 commits into from

Conversation

MAudelGisaia
Copy link
Contributor

QuCMGisaia
QuCMGisaia approved these changes Dec 20, 2024
View reviewed changes
scripts/start.sh Outdated
@@ -508,6 +508,17 @@ fi
envsubst '$ARLAS_ENABLE_H3' < /usr/share/nginx/html/settings.yaml > /usr/share/nginx/html/settings.yaml.tmp
mv /usr/share/nginx/html/settings.yaml.tmp /usr/share/nginx/html/settings.yaml

# Allow applying an geohash/geotile aggregation on a geoshape field
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an -> a

scripts/start.sh Outdated
if [ -z "${ARLAS_GEOSHAPE_AGG}" ]; then
ARLAS_GEOSHAPE_AGG=false
export ARLAS_GEOSHAPE_AGG
echo "geohash/geotile aggregation on a geoshape field are not allowed"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are -> is

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 9, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuCMGisaia QuCMGisaia QuCMGisaia approved these changes

@sebbousquet sebbousquet Awaiting requested review from sebbousquet

@mbarbet mbarbet Awaiting requested review from mbarbet

@MohamedHamouGisaia MohamedHamouGisaia Awaiting requested review from MohamedHamouGisaia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow applying an geohash/geotile aggregation on a geoshape field
2 participants
@MAudelGisaia @QuCMGisaia