Fix Garbage Collection of Delegates #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keeps a reference to the MarshalCallback delegate to prevent the Garbage Collector from collecting it while still in use. Partially fixes #82
Stops the Garbage Collector from collecting the WeakNotify delegate used by Object.cs to dispose of unmanaged resources. This should be the last instance of garbage collected delegates, but the fix is quite simple if we encounter this issue again. Fixes #82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeps a reference to any delegates we use to avoid upsetting the garbage collector when low on RAM.
The culprits seem to be the following two delegates, which I've gone ahead and fixed:
MarshalCallbackinClosureHelper.csOnFinalizedinObject.csI'm not finding anything else, but if we do encounter this later the fix is rather straightforward. We can avoid this by holding a strong reference to any delegates we pass to GLib.
Fixes #82