Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widget Catalog Samples #103

Merged
merged 23 commits into from
Dec 10, 2020
Merged

Widget Catalog Samples #103

merged 23 commits into from
Dec 10, 2020

Conversation

na2axl
Copy link
Member

@na2axl na2axl commented Nov 4, 2020

This PR will add the most wanted Widget Catalog, to showcase how to create widgets using the Gir.Core's Core layer.

Fixes #88.

@na2axl na2axl added documentation Improvements or additions to documentation Enhancement New feature or request labels Nov 4, 2020
@na2axl na2axl self-assigned this Nov 4, 2020
badcel
badcel reviewed Nov 8, 2020
View reviewed changes
Libs/GObject/GObject.csproj Outdated Show resolved Hide resolved
This was referenced Nov 17, 2020
Open
Merged
Open
@na2axl na2axl marked this pull request as ready for review November 29, 2020 16:27
badcel
badcel requested changes Dec 3, 2020
View reviewed changes
Copy link
Member

@badcel badcel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Only one little thing regarding TextView constructor 👍

Libs/Gtk3/Classes/TextView.cs Outdated Show resolved Hide resolved
@badcel
Copy link
Member

badcel commented Dec 3, 2020

This does not finish #88 as the catalog is missing? We can merge neverteless but keep the issue open.

@na2axl
Copy link
Member Author

na2axl commented Dec 3, 2020

Hi @badcel, @firox263, I think this PR is ready for a review. It's not complete as I want, but I prefer follow your advice and do many little iterations on classes implementation. This PR comes with:

  • IObject interface (Every GObject, and GInterface implements IObject)
  • Interface properties
  • Interface implementation in classes
  • Full implementation of AccelGroup, AboutDialog, and Window classes

@na2axl na2axl requested a review from a team December 3, 2020 13:47
@badcel badcel requested a review from mjakeman December 3, 2020 13:53
@na2axl
Copy link
Member Author

na2axl commented Dec 3, 2020

This does not finish #88 as the catalog is missing? We can merge neverteless but keep the issue open.

Yes this PR doesn't introduce the WidgetCatalog, I want to implement some classes before like Widget, Box, Container, Button and more, and also show how to create custom classes. This PR is not enough for that...

I will reopen #88 if this PR got merged.

@badcel
Copy link
Member

badcel commented Dec 5, 2020

@firox263 if you approve this can be merged.

mjakeman
mjakeman requested changes Dec 5, 2020
View reviewed changes
Copy link
Member

@mjakeman mjakeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! @na2axl

This looks good to me for the most part, only a few points about [Obsolete] warning suppression, some accidentally commented-out attributes, and consistency with error handling.

Once this is fixed, I think this is good to merge 👍

Libs/Gtk3/Classes/AccelGroup.cs Show resolved Hide resolved
Libs/Gtk3/Classes/Button.cs Outdated Show resolved Hide resolved
Libs/Gtk3/Classes/MenuItem.cs Outdated Show resolved Hide resolved
Libs/Gtk3/Classes/RecentChooserMenu.cs Outdated Show resolved Hide resolved
Libs/Gtk3/Classes/Switch.cs Outdated Show resolved Hide resolved
Libs/Gtk3/Classes/ToolItem.cs Outdated Show resolved Hide resolved
Libs/Gtk3/Classes/Window.cs Outdated Show resolved Hide resolved
Libs/Gtk3/Classes/Window.cs Outdated Show resolved Hide resolved
Libs/Gtk3/Classes/Window.cs Outdated Show resolved Hide resolved
Libs/Gtk3/Classes/Window.cs Outdated Show resolved Hide resolved
@na2axl na2axl mentioned this pull request Dec 8, 2020
Closed
14 tasks
@badcel
Copy link
Member

badcel commented Dec 8, 2020

@firox263 For me this is now good to merge. If you agree please merge 👍

@badcel badcel mentioned this pull request Dec 8, 2020
Merged
@na2axl
Copy link
Member Author

na2axl commented Dec 8, 2020

@badcel @firox263 I prefer to merge #117 and #116 before, I will then rebase on develop and fix any conflicts

@badcel
Copy link
Member

badcel commented Dec 8, 2020

Okay I thought the other way around that we start with this PR. But actually the order does not matter, it is just the question who has to adopt to the changes. If you like to start with my PRs I'm fine with it as it saves me some work 👍

@mjakeman mjakeman self-requested a review December 9, 2020 02:52
mjakeman
mjakeman approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@mjakeman mjakeman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to merge.

Do we want to merge this or #116/#117 first?

Edit: Reading @na2axl's comment, let's merge #116/#117.

na2axl added 20 commits December 10, 2020 19:33
@na2axl
[WIP] Update projects and dependencies
8ff1f41
@na2axl
Remove the Orientable.cs file
051190c
@na2axl
Make Property based on IObject instead of Object
9b2e2a0
@na2axl
Make Object implement IObject
88fac35
@na2axl
✨ Fully implement the AboutDialog widget
47578fb
@na2axl
Revert target framework changes
b105f72
@na2axl
Add class comment imported from GTK docs
290b7d2
@na2axl
✨ Fully implement the AccelGroup class
e213a95
@na2axl
Update property descriptors generation
a6fcc11
@na2axl
✨ Fully implement the Window widget
3297907
@na2axl
Fix missing implementation is Gio
c588853
@na2axl
Fix missing implementation is Gtk
4bc435a
@na2axl
Fix generation errors on interfaces
1efef1d
@na2axl
Remove comments
e85ef11
@na2axl
Remove empty constructor
ed9e5cf
@na2axl
Fix pragma warnings for obsolete code
7b7947d
@na2axl
Restore empty constructor in TextView.cs
b4ba3eb
@na2axl
Comment code until we find a solution about closures (#119)
087c469
@na2axl
Fix nullable types
69f849b
@na2axl
Apply editor config settings
b3d5871
@na2axl na2axl merged commit 05a1412 into develop Dec 10, 2020
@na2axl na2axl deleted the widget_catalog branch December 10, 2020 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@badcel badcel badcel approved these changes

@mjakeman mjakeman mjakeman approved these changes

Assignees

@na2axl na2axl

Labels
documentation Improvements or additions to documentation Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a WidgetCatalog sample
3 participants
@na2axl @badcel @mjakeman