Merge pull request #529 from gircore/fix/boxed_record_construction

Fix creation of boxed records
gircore · Jan 21, 2022 · 395bf92 · 395bf92
2 parents 187f691 + a8ecbef
commit 395bf92
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/src/Generation/Generator3/Generation/Record/PublicClass/PublicClassModel.cs b/src/Generation/Generator3/Generation/Record/PublicClass/PublicClassModel.cs
@@ -8,6 +8,8 @@ public class PublicClassModel
 
         public string Name => _record.GetPublicClassName();
         public string InternalHandleName => _record.GetInternalHandleName();
+        public string InternalOwnedHandleName => _record.GetInternalOwnedHandleName();
+        public string InternalUnownedHandleName => _record.GetInternalUnownedHandleName();
         public string NamespaceName => _record.Namespace.Name;
 
         public PublicClassModel(GirModel.Record record)

diff --git a/src/Generation/Generator3/Generation/Record/PublicClass/PublicClassTemplate.cs b/src/Generation/Generator3/Generation/Record/PublicClass/PublicClassTemplate.cs
@@ -31,6 +31,12 @@ public partial class {model.Name} : GLib.IHandle
             Initialize();
         }}
 
+        //TODO: This is a workaround constructor as long as we are
+        //not having https://github.com/gircore/gir.core/issues/397
+        private {model.Name}(IntPtr ptr, bool ownsHandle) : this(ownsHandle
+            ? new Internal.{model.InternalOwnedHandleName}(ptr)
+            : new Internal.{model.InternalUnownedHandleName}(ptr)){{ }}
+
         // TODO: Default Constructor (allocate in managed memory and free on Dispose?)
         // We need to be able to create instances of records with full access to
         // fields, e.g. Gdk.Rectangle, Gtk.TreeIter, etc.