Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Incident Details Modal #435

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

giranm
Copy link
Owner

@giranm giranm commented Jan 18, 2023

Summary

This PR closes #144 which provides a dedicated incident details page for PagerDuty Live.

THIS IS CURRENTLY BEING WORKED ON AS A DRAFT

TODO

  • Create onClick handler and redux framework that toggles IncidentDetailsModalComponent when an incident row is selected/clicked in the main table.
  • Ensure that the store for reducer incidentDetails is updated with the "currentIncident" to be viewed (upon above action)
  • Update IncidentDetailsModalComponent to display data from incidentDetails.incident
  • Update SettingsModal to account for customisation of the alerts table (will require similar redux plumbing)
  • Create src/redux/alerts_table which mimics interactivity of src/redux/incident_table (e.g. store alerts table layout)
  • Update AlertsTableComponent to mimic IncidentTableComponent, except pointing to the alerts redux plumbing
  • Update styling via SCSS and custom classNames for friendly UI/UX
  • Add i18n & react-i18next translation tokens as required
  • (Optional) Add alert specific actions to AlertsTableComponent

@giranm giranm added the enhancement New feature or request label Jan 18, 2023
@giranm giranm added this to the Beta milestone Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant