Add minimum length for responses to be gzipped #20
+154
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Very short responses become larger if they are gzipped. With the minLength parameter you can define what minimum length a response should have before it is gzipped. The response is buffered up to the minimum length. As soon as the length of the response becomes larger than the minimum length, the buffered part will be written to the gzip writer and the headers will be set accordingly. After that no more buffering will be applied. If the response stays shorter than the minimum length, it will stay uncompressed and no Accept-Encoding and Vary headers will be set.
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
=======================================
- Coverage 90.24% 90% -0.25%
=======================================
Files 1 1
Lines 41 60 +19
=======================================
+ Hits 37 54 +17
- Misses 3 4 +1
- Partials 1 2 +1
Continue to review full report at Codecov.
|
vvalkonen
reviewed
Sep 2, 2024
| @@ -39,7 +39,7 @@ import ( | |||
|
|
|||
| func main() { | |||
| r := gin.Default() | |||
| r.Use(gzip.Gzip(gzip.DefaultCompression)) | |||
| r.Use(gzip.Gzip(gzip.DefaultCompression, 0)) | |||
There was a problem hiding this comment.
I'm not part of the project but can you add this by using options pattern so it doesn't break all the existing code out there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very short responses become larger if they are gzipped. With
the minLength parameter you can define what minimum length a
response should have before it is gzipped. The response is
buffered up to the minimum length. As soon as the length of
the response becomes larger than the minimum length, the buffered
part will be written to the gzip writer and the headers will be
set accordingly. After that no more buffering will be applied.
If the response stays shorter than the minimum length, it will
stay uncompressed and no Accept-Encoding and Vary headers will
be set.