Corrige lógica de conversão para booleano no método to_b em lead.rb

gildemberg-santos · Apr 28, 2024 · 5b0b11e · 5b0b11e
1 parent 02fc22a
commit 5b0b11e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/lib/salesforce/lead.rb b/lib/salesforce/lead.rb
@@ -70,6 +70,7 @@ def field!
         remove_fields = %w[FirstName LastName].include?(field["name"])
         createable = field["createable"] == false
         remove_type = %w[reference].include?(field["type"])
+        remove_required = field["nillable"] == false && field["type"] != "boolean"
         @fields.merge!({ field["name"] => { "type" => field["type"], "title" => field["label"] } })
 
         next if (not_remove_fields && createable) || (not_remove_fields && remove_type) || remove_fields
@@ -79,7 +80,7 @@ def field!
           field_temp[field["name"]].merge!(create_enum(field["picklistValues"]))
         end
 
-        @required_fields.append(field["name"]) if field["nillable"] == false
+        @required_fields.append(field["name"]) if remove_required
         @normalized_fields.merge!(field_temp)
       end
       nil

diff --git a/spec/lib/salesforce/lead_spec.rb b/spec/lib/salesforce/lead_spec.rb
@@ -52,4 +52,6 @@
       @lead.send({ "Company" => "Test", "LastName" => "Test" })["success"]
     ).to eq true
   }
+
+  it { expect(@lead.required_fields).to eq(%w[Name Company Status]) }
 end