Excise Extra take 2 (Kwarg tags) #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Where n is the number of #'s. (Not variadic.) !/Extras will be obsoleted. They still need a primary, so, for now, they will only work on unary.
Tag kwarg prefixes were ignored when the value was a Pack. Now it's an error.
|
Commits are not structured as well as I would like, but I was rapid-prototyping. I have to sync up or nothing happens. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #245 +/- ##
===========================================
- Coverage 100.00% 98.89% -1.11%
===========================================
Files 6 6
Lines 719 724 +5
Branches 113 111 -2
===========================================
- Hits 719 716 -3
- Misses 0 5 +5
- Partials 0 3 +3 ☔ View full report in Codecov by Sentry. |
This was referenced Dec 24, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retry of #244. I kept most of the commits and made some changes on top. It will need similar follow-up as described there.
Resolves #187.