Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add array operators #21

Closed
wants to merge 1 commit into from
Closed

Conversation

afilp
Copy link

@afilp afilp commented Oct 31, 2023

More info here: nestjsx#754

@zaro
Copy link
Member

zaro commented Nov 1, 2023

@afilp unfortunately tests are failing with this change. I spend some time trying to figure out what causes it, but it's not obvious at all.

I don't have time in the next few days to figure it out, so it will have to wait until I have time...

@afilp
Copy link
Author

afilp commented Nov 1, 2023

Sure!

I just copied/pasted the old code from that PR:
nestjsx#754

So, that you can have a start. Most likely that old code would fail somewhere.

@zaro
Copy link
Member

zaro commented Nov 10, 2023

@afilp this is merged and released as 5.3.1 .

@zaro zaro closed this Nov 10, 2023
@afilp
Copy link
Author

afilp commented Nov 11, 2023

@afilp Does it work eventually? Without any changes? Thanks!

@zaro
Copy link
Member

zaro commented Nov 11, 2023

@afilp I don't understand do you mean?

Install v5.3.1 and check if it's working. I fixed the tests, but I didn't have time to test the two new array operators. The branch is actually meged, but I closed the PR, because it was way more work to merge it trough the PR.

As for the changes, I had to make a trivial change because of small refractor that this PR is doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants