Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

call _preset_args_changed instead of changing selection #1

Conversation

kecnry
Copy link

@kecnry kecnry commented Apr 12, 2024

This PR is to avoid having to change the current footprint selection in order to force an update through _preset_args_changed

@gibsongreen
Copy link
Owner

gibsongreen commented Apr 12, 2024

This PR is to avoid having to change the current footprint selection in order to force an update through _preset_args_changed

Thank you, I do see what I was missing in `preset_args_changed'. I rebased my branch and visually testing it, and its resulting in buggy behavior. If I create 2 custom footprints with different ra/dec values, they are loading in the same location (until the overlay selected in the UI is changed, then it reloads in the correct location).

It isn't obvious to me why iterating through the exposed overlay.selected results in different behavior since the only other call would be change_overlay and there doesn't seem to be anything in there that would effect this specific behavior.

Irregardless I am putting together the regression test and see if I can get to the bottom of why this approach results in different behavior from going through exposed functionality.

Untitled.2.mov

@gibsongreen gibsongreen merged commit 33f4088 into gibsongreen:fp_api_before_wcs Apr 16, 2024
2 checks passed
@kecnry kecnry deleted the fp-refactor-to-update-non-selected branch April 16, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants