Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAPI: Request observability-bundle v1.9.0. #1500

Merged
merged 1 commit into from
Nov 18, 2024
Merged

CAPI: Request observability-bundle v1.9.0. #1500

merged 1 commit into from
Nov 18, 2024

Conversation

QuantumEnigmaa
Copy link
Contributor

Checklist

  • Roadmap issue created
  • Release uses latest stable Flatcar
  • Release uses latest Kubernetes patch version

Triggering E2E tests

To trigger the E2E test for each new Release added in this PR, add a comment with the following:

/run releases-test-suites

If you want to trigger conformance tests, you can do so by adding a comment similar to the following:

/run conformance-tests PROVIDER=capa RELEASE_VERSION=29.1.0

For more details see the README.md.

@QuantumEnigmaa QuantumEnigmaa requested a review from a team November 18, 2024 12:42
@QuantumEnigmaa QuantumEnigmaa self-assigned this Nov 18, 2024
@QuantumEnigmaa QuantumEnigmaa requested a review from a team as a code owner November 18, 2024 12:42
@QuentinBisson
Copy link
Contributor

Can you also add it into capz and capv?

@QuantumEnigmaa
Copy link
Contributor Author

@QuentinBisson done

@QuantumEnigmaa

This comment was marked as outdated.

Sign in to view
@tinkerers-ci

This comment was marked as outdated.

Sign in to view
@QuantumEnigmaa
Copy link
Contributor Author

releases-test-suites failed with the following message :

TEST_SUITES is not set, finding test suites for each Release...


⚠️ No valid Release / Test Suite pairings found!

@QuantumEnigmaa
Copy link
Contributor Author

Do I need to specify the TEST-SUITES variable ?

Gacko
Gacko requested changes Nov 18, 2024
View reviewed changes
Copy link
Member

@Gacko Gacko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a minor app version bump. We will not deliver such a change in a patch release. See the versioning section in the docs for further details about patch releases:

https://intranet.giantswarm.io/docs/product/releases/capi/capi-versioning-scope/#versioning

The general rule for patch releases is that they have zero impact for customers and do not require rolling nodes. They are used for fixing a problem in the predecessor, temporary mitigations, or other changes that do not require customer action.

Also we already released a CAPA v29.4.0 with Observability Bundle v1.8.0 and the upcoming CAPZ v29.3.0 is aligned to that. Last but not least you forgot vSphere. I'll fix that for you.

Do I need to specify the TEST-SUITES variable ?

You don't need to run tests for requesting app versions.

@Gacko Gacko added the skip/ci Instructs PR Gatekeeper to ignore any required PR checks label Nov 18, 2024
@Gacko Gacko changed the title add observability-bundle request for release >=29.4.1 CAPI: Request observability-bundle v1.9.0. Nov 18, 2024
@Gacko Gacko merged commit 0691e50 into master Nov 18, 2024
5 checks passed
@Gacko Gacko deleted the add-ollybundle-request branch November 18, 2024 20:14
@QuantumEnigmaa
Copy link
Contributor Author

Thx a lot @Gacko ! 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuentinBisson QuentinBisson QuentinBisson approved these changes

@Gacko Gacko Gacko approved these changes

Assignees

@QuantumEnigmaa QuantumEnigmaa

Labels
skip/ci Instructs PR Gatekeeper to ignore any required PR checks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@QuantumEnigmaa @QuentinBisson @Gacko