Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add CNPs for write and backend pods #293

Merged
merged 3 commits into from
Feb 21, 2024
Merged

add CNPs for write and backend pods #293

merged 3 commits into from
Feb 21, 2024

Conversation

QuantumEnigmaa
Copy link
Contributor

Towards giantswarm/roadmap#3189

These CNPs could otherwise be added as extra-objects in the config. Or we could create an "additionalCiliumNetPols" field upstream (or something of the sort).
Until we decide on any of those, this will allow loki to work on CAPVCD clusters

@QuantumEnigmaa QuantumEnigmaa self-assigned this Feb 20, 2024
@QuantumEnigmaa QuantumEnigmaa requested a review from a team as a code owner February 20, 2024 12:29
@QuantumEnigmaa QuantumEnigmaa force-pushed the additional-ciliumnetpols branch from e29a51b to c4f59f6 Compare February 20, 2024 12:29
QuentinBisson
QuentinBisson approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@QuentinBisson QuentinBisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tested also on vintage :)

@QuantumEnigmaa
Copy link
Contributor Author

This was tested on both gerbil and golem and it works as intended. But since on vintage these fields will be disabled I'm not sure we need to test it there 🤷

@QuentinBisson
Copy link
Contributor

Sure :) then make sure to also do the config change

@QuantumEnigmaa
Copy link
Contributor Author

Side note concerning golem : with or without the CNPs the gateway pods as well as the promtail ones are experiencing issues.

gateway pods :

100.64.0.78 - golem [20/Feb/2024:15:41:53 +0000]  502 "POST /loki/api/v1/push HTTP/1.1" 157 "-" "GrafanaAgent/v0.37.2" "3.11.43.118"
2024/02/20 15:41:55 [crit] 10#10: *3974 connect() to 172.31.98.99:3101 failed (1: Operation not permitted) while connecting to upstream, client: 100.64.4.134, server: , request: "POST /loki/api/v1/push HTTP/1.1", upstream: "http://172.31.98.99:3101/loki/api/v1/push", host: "loki.golem.gaws.gigantic.io

promtail :

level=warn ts=2024-02-20T15:40:27.606152414Z caller=client.go:419 component=client host=loki.golem.gaws.gigantic.io msg="error sending batch, will retry" status=502 tenant=golem error="server returned HTTP status 502 Bad Gateway (502): <html>"

So adding the CNPs didn't change anything but still I'm a bit troubled by this

@marieroque
Copy link
Contributor

No more error on golem, it was related to https://github.com/giantswarm/loki-app/blob/master/CHANGELOG.md#fixed
We had to delete the loki-multi-tenant-proxy deployment.

marieroque
marieroque approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@marieroque marieroque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuantumEnigmaa QuantumEnigmaa merged commit c0ed51f into master Feb 21, 2024
5 checks passed
@QuantumEnigmaa QuantumEnigmaa deleted the additional-ciliumnetpols branch February 21, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marieroque marieroque marieroque approved these changes

@QuentinBisson QuentinBisson QuentinBisson approved these changes

Assignees

@QuantumEnigmaa QuantumEnigmaa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@QuantumEnigmaa @QuentinBisson @marieroque