Adding fixes for dynamic-scheduler #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHK
commented
Oct 7, 2024
services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/core/settings.py
Outdated
Show resolved
Hide resolved
services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/cli.py
Outdated
Show resolved
Hide resolved
added 5 commits
October 8, 2024 07:41
…upgrade-dynamic-sceduler
…ade-dynamic-sceduler
added 2 commits
October 8, 2024 09:02
…upgrade-dynamic-sceduler
giancarloromeo
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
I think I've ported the base changes for the scheduler. We still need to talk about a few things. There is a validator that we might want to transform into a utility for the settings.
@giancarloromeo please assign me to this PR and add yourself as a reviewer so we can work on this one, thanks!
Related issue/s
How to test
Dev-ops checklist