Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: 3-arg subtraction was not implemented. #102

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TheHamhams
Copy link

We promised customers that we would have this in our initial release, to this is a bug, not an enhancement

Required Steps

  • Check with the product owner
  • Write tests
  • Update docs
  • Get code review

Testing Done

…that we would have this in our initial release, to this is a bug, not an enhancement
@TheHamhams TheHamhams marked this pull request as ready for review May 9, 2023 15:57
@TheHamhams TheHamhams marked this pull request as draft May 9, 2023 15:58
Updated comments.
@TheHamhams TheHamhams marked this pull request as ready for review May 9, 2023 16:07
Copy link
Author

@TheHamhams TheHamhams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo

@@ -17,6 +17,11 @@ def test_sub_2arg(self):
# Make sure 4 - 3 = 1
self.assertEqual(sub(4, 3), 1, 'subtracting three from four')


def test_sub_3arg(self):
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheHamhams TheHamhams marked this pull request as draft May 9, 2023 16:20
@TheHamhams TheHamhams marked this pull request as ready for review May 9, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant