Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make : deprecate #10514

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

make : deprecate #10514

wants to merge 1 commit into from

Conversation

ggerganov
Copy link
Owner

ref #10268

Disabling the Makefile unless LLAMA_MAKEFILE is defined. This should give more focus for the CMake build and will help clean-up any usage of make in the existing CI. The Makefile will be eventually removed or stripped to a very minimal version.

@MaggotHATE
Copy link
Contributor

stripped to a very minimal version

That would be a much more preferred option. Like LostRuins mentioned in the original discussion, Makefile is a very simple and handy option that gives additional flexibility to projects that use llama.cpp, and it is multiplatform.

If you see the current state of Makefile as a burden, it is worth at least leaving a simplified version - for example, main and server as the most popular applications. This would serve not only as a quick "build and test" option, but also as an example for those who use Makefile in their projects. Then, for all advanced options users can be directed towards CMake only.

@slaren
Copy link
Collaborator

slaren commented Nov 26, 2024

Is there a single platform that does not have easy access to cmake? If typing two commands instead of one is too much effort, we can always have the Makefile run cmake. In any case, let's keep that discussion to #10268.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants