[Ray-tracing] Change index offset to first index #6873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
requested changes
Jan 8, 2025
Co-authored-by: Connor Fitzgerald <[email protected]>
# Conflicts: # wgpu-core/src/command/ray_tracing.rs
I can't seem to find the question, what is it? |
|
That's a very interesting question.... let me look to see if I can remember what |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Mentioned on matrix as being confusing.
Description
index_buffer_offsetis validated that the offset is divisible by the size of the index type, this suggests that it is probably better - and less confusing - if this is changed to be called first index and is multiplied by the size of the index type.Testing
This is a change mostly to naming - it shouldn't need any new tests.
Checklist
cargo fmt.taplo format.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.