Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify cases for Select argument type mismatch diagnostics #6792

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Clarify cases for Select argument type mismatch diagnostics #6792

merged 2 commits into from
Dec 20, 2024

Conversation

ErichDonGubler
Copy link
Member

No description provided.

@ErichDonGubler ErichDonGubler added area: validation Issues related to validation, diagnostics, and error handling naga Shader Translator area: naga processing Passes over IR in the middle kind: diagnostics Error message should be better labels Dec 19, 2024
@ErichDonGubler ErichDonGubler self-assigned this Dec 19, 2024
@ErichDonGubler ErichDonGubler requested a review from a team as a code owner December 19, 2024 19:57
@ErichDonGubler ErichDonGubler changed the title Clarify cases for Select argument type mismatches Clarify cases for Select argument type mismatch diagnostics Dec 19, 2024
teoxoy
teoxoy approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@cwfitzgerald cwfitzgerald merged commit 6c9f93b into gfx-rs:trunk Dec 20, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoxoy teoxoy teoxoy approved these changes

Assignees

@ErichDonGubler ErichDonGubler

Labels
area: naga processing Passes over IR in the middle area: validation Issues related to validation, diagnostics, and error handling kind: diagnostics Error message should be better naga Shader Translator
Projects
WebGPU for Firefox
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ErichDonGubler @teoxoy @cwfitzgerald