Enforce fmt. of *.{md,js,html,yml} with prettier
#6368
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErichDonGubler
force-pushed
the
fmt-md-js-html-yml
branch
3 times, most recently
from
89b9537 to
e1af03a
Compare
| - name: "Format `**/*.{md,js,html,yml}` files" | ||
| uses: creyD/[email protected] | ||
| with: | ||
| prettier_version: 3.3.3 |
There was a problem hiding this comment.
Could we lift this to an env_var in the table up top.
.prettierrc.toml
Outdated
There was a problem hiding this comment.
Why does this need to exist?
There was a problem hiding this comment.
Because otherwise, prettier tries to format these files. I didn't think it was valuable to do that, since these files are handled with automation.
Thoughts, @gfx-rs/naga?
ErichDonGubler
changed the title
*.{md,js,html,yml} with prettier
ErichDonGubler
force-pushed
the
fmt-md-js-html-yml
branch
2 times, most recently
from
4b79e76 to
97522db
Compare
ErichDonGubler
force-pushed
the
fmt-md-js-html-yml
branch
3 times, most recently
from
60a544d to
4bceb5d
Compare
ErichDonGubler
force-pushed
the
fmt-md-js-html-yml
branch
2 times, most recently
from
615fff9 to
feac44d
Compare
ErichDonGubler
force-pushed
the
fmt-md-js-html-yml
branch
from
feac44d to
efe731b
Compare
This actually may enforce the format of other files than these, but it's unlikely.
ErichDonGubler
force-pushed
the
fmt-md-js-html-yml
branch
from
efe731b to
6629758
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
-
Description
Title says all. See commits for more details.
Testing
CI!
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.Add change toNot necessary.CHANGELOG.md. See simple instructions inside file.prettierwants to change, to get parity with other tools.