Skip to content

Commit

Permalink
Use HLSL 2018
Browse files Browse the repository at this point in the history
  • Loading branch information
daxpedda committed Nov 9, 2023
1 parent 49b7ec9 commit c3856cf
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion wgpu-hal/src/dx12/shader_compilation.rs
Original file line number Diff line number Diff line change
Expand Up @@ -142,9 +142,12 @@ mod dxc {
log::Level,
) {
profiling::scope!("compile_dxc");
let mut compile_flags = arrayvec::ArrayVec::<&str, 4>::new_const();
let mut compile_flags = arrayvec::ArrayVec::<&str, 6>::new_const();

Check warning on line 145 in wgpu-hal/src/dx12/shader_compilation.rs

View check run for this annotation

Codecov / codecov/patch

wgpu-hal/src/dx12/shader_compilation.rs#L145

Added line #L145 was not covered by tests
compile_flags.push("-Ges"); // d3dcompiler::D3DCOMPILE_ENABLE_STRICTNESS
compile_flags.push("-Vd"); // Disable implicit validation to work around bugs when dxil.dll isn't in the local directory.
compile_flags.push("-HV"); // Use HLSL 2018, Naga doesn't supported 2021 yet.
compile_flags.push("2018");

Check warning on line 150 in wgpu-hal/src/dx12/shader_compilation.rs

View check run for this annotation

Codecov / codecov/patch

wgpu-hal/src/dx12/shader_compilation.rs#L148-L150

Added lines #L148 - L150 were not covered by tests
if device
.private_caps
.instance_flags
Expand Down

0 comments on commit c3856cf

Please sign in to comment.