Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] Handle invalid spec on a spec with multiple spec setup #79

Merged
merged 4 commits into from
Jan 18, 2024
Merged

[bugfix] Handle invalid spec on a spec with multiple spec setup #79

merged 4 commits into from
Jan 18, 2024

Conversation

pboos
Copy link
Collaborator

@pboos pboos commented Jan 18, 2024

Steps to reproduce

  • Setup with multiple specs
  • Have one (or more) spec be invalid
  • Startup

Expected behaviour

  • It should log the failure
  • It should ignore that spec (&path) but otherwise work the same still

Actual behaviour

  • It logs the failure
  • It throws an NPE whenever an endpoint with the invalid spec is validated

@pboos pboos requested a review from a team as a code owner January 18, 2024 12:45
@pboos pboos requested a review from dominik-riha January 18, 2024 12:45
@pboos pboos merged commit 1deeb62 into main Jan 18, 2024
2 checks passed
@pboos pboos deleted the bugfix/multispec-null-validator-handling branch January 18, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eleonoraborghi eleonoraborghi eleonoraborghi approved these changes

@dominik-riha dominik-riha Awaiting requested review from dominik-riha dominik-riha is a code owner automatically assigned from getyourguide/chk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pboos @eleonoraborghi