Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactoring to improve code quality #67

Merged
merged 4 commits into from
Nov 28, 2023
Merged

refactoring to improve code quality #67

merged 4 commits into from
Nov 28, 2023

Conversation

pboos
Copy link
Collaborator

@pboos pboos commented Nov 27, 2023

Refactoring to improve code quality doing the following

  • extract mapper
  • pass in OpenApiViolationHandler to interceptor and webfilter
  • throttling and exclusions through decrated OpenApiViolationHandler

@pboos pboos requested a review from a team as a code owner November 27, 2023 14:45
@pboos pboos requested a review from eleonoraborghi November 27, 2023 14:45
eleonoraborghi
eleonoraborghi approved these changes Nov 28, 2023
View reviewed changes
Copy link

@eleonoraborghi eleonoraborghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!!

@pboos pboos merged commit 4da8b57 into main Nov 28, 2023
2 checks passed
@pboos pboos deleted the change/refactoring branch November 28, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eleonoraborghi eleonoraborghi eleonoraborghi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pboos @eleonoraborghi