Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: do not report violation on blocked request #66

Merged
merged 13 commits into from
Nov 24, 2023

Conversation

pboos
Copy link
Collaborator

@pboos pboos commented Nov 23, 2023

When should-fail-on-request-violation is enabled it will fail with a 400. In this case it should not report a violation as the request was correctly rejected.

@pboos pboos requested a review from a team as a code owner November 23, 2023 13:04
@pboos pboos requested a review from eleonoraborghi November 23, 2023 13:04
Copy link

@eleonoraborghi eleonoraborghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trusting the tests!

@pboos pboos merged commit 70f07bd into main Nov 24, 2023
1 check passed
@pboos pboos deleted the bugfix/dont-report-violation-on-blocked-request branch November 24, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants