Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Ignore violation operation not allowed with status code 404 #45

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

pboos
Copy link
Collaborator

@pboos pboos commented Oct 19, 2023

If there is a request returning 404 that triggers a validation.request.operation.notAllowed violation, this should not be logged as a violation.

Reason: 404 is the expected response for a not specified operation.

@pboos pboos requested a review from a team as a code owner October 19, 2023 11:51
@pboos pboos requested a review from huguenin October 19, 2023 11:51
Copy link

@eleonoraborghi eleonoraborghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it

@pboos pboos merged commit 7565dd0 into main Oct 20, 2023
1 check passed
@pboos pboos deleted the bugfix/ignore-404-operation-not-allowed branch October 20, 2023 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants