do not log request violation if shouldFailOnRequestViolation

getyourguide · Nov 23, 2023 · 8857839 · 8857839
1 parent b6bcb9d
commit 8857839
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/.../java/com/getyourguide/openapi/validation/core/OpenApiRequestValidationConfiguration.java b/.../java/com/getyourguide/openapi/validation/core/OpenApiRequestValidationConfiguration.java
@@ -8,4 +8,5 @@
 public class OpenApiRequestValidationConfiguration {
     private double sampleRate;
     private int validationReportThrottleWaitSeconds;
+    private boolean shouldFailOnRequestViolation;
 }
diff --git a/...-core/src/main/java/com/getyourguide/openapi/validation/core/OpenApiRequestValidator.java b/...-core/src/main/java/com/getyourguide/openapi/validation/core/OpenApiRequestValidator.java
@@ -23,6 +23,7 @@ public class OpenApiRequestValidator {
     private final ThreadPoolExecutor threadPoolExecutor;
     private final OpenApiInteractionValidatorWrapper validator;
     private final ValidationReportHandler validationReportHandler;
+    private final OpenApiRequestValidationConfiguration configuration;
 
     public OpenApiRequestValidator(
         ThreadPoolExecutor threadPoolExecutor,
@@ -34,6 +35,7 @@ public OpenApiRequestValidator(
         this.threadPoolExecutor = threadPoolExecutor;
         this.validator = validator;
         this.validationReportHandler = validationReportHandler;
+        this.configuration = configuration;
 
         metricsReporter.reportStartup(
             validator != null,
@@ -74,7 +76,12 @@ public ValidationResult validateRequestObject(
         try {
             var simpleRequest = buildSimpleRequest(request, requestBody);
             var result = validator.validateRequest(simpleRequest);
-            validationReportHandler.handleValidationReport(request, response, Direction.REQUEST, requestBody, result);
+            // TODO this should not be done here, but currently the only way to do it -> Refactor this so that logging
+            //      is actually done in the interceptor/filter where logging can easily be skipped then.
+            if (!configuration.isShouldFailOnRequestViolation()) {
+                validationReportHandler
+                    .handleValidationReport(request, response, Direction.REQUEST, requestBody, result);
+            }
             return buildValidationResult(result);
         } catch (Exception e) {
             log.error("Could not validate request", e);

diff --git a/...main/java/com/getyourguide/openapi/validation/OpenApiValidationApplicationProperties.java b/...main/java/com/getyourguide/openapi/validation/OpenApiValidationApplicationProperties.java
@@ -88,6 +88,7 @@ public OpenApiRequestValidationConfiguration toOpenApiRequestValidationConfigura
         return OpenApiRequestValidationConfiguration.builder()
             .sampleRate(getSampleRate())
             .validationReportThrottleWaitSeconds(getValidationReportThrottleWaitSeconds())
+            .shouldFailOnRequestViolation(getShouldFailOnRequestViolation())
             .build();
     }
 }