istio-router-check: wip poc #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
cainelli
commented
Jul 9, 2024
cainelli
commented
- Move it to hack directory as it is still rough edges and early development.
- Drop wrapping of router_check_tool and just make it a generator of VirtualService to Envoy routes and aggregator of tests.
- Rough conversion support of existing testing format to keep it running internally as PoC.
- Support 'gateway view' when parsing VirtualServices.
Signed-off-by: Fernando Cainelli <[email protected]>
Signed-off-by: Fernando Cainelli <[email protected]>
Signed-off-by: Fernando Cainelli <[email protected]>
Signed-off-by: Fernando Cainelli <[email protected]>
Signed-off-by: Fernando Cainelli <[email protected]>
Smeb
reviewed
Jul 10, 2024
Smeb
reviewed
Jul 10, 2024
Smeb
reviewed
Jul 10, 2024
| cmd.Flags().IntVarP(&rootCmd.Verbosity, "", "v", LevelInfo, "log verbosity level") | ||
| cmd.Flags().StringVarP(&rootCmd.Gateway, "gateway", "", "", "only consider VirtualServices bound to this gateway") | ||
| cmd.Flags().StringVarP(&rootCmd.ConfigDir, "config-dir", "c", "", "directory containing Istio VirtualService and Gateway configs") | ||
| cmd.Flags().StringVarP(&rootCmd.TestDir, "test-dir", "t", "", "directory containing old format tests") |
There was a problem hiding this comment.
Is this still the old format?
There was a problem hiding this comment.
I consolidated to a single test-dir flag and control if is Envoy or istio-config-validator format through a hidden --convert-tests.
Smeb
reviewed
Jul 10, 2024
Smeb
reviewed
Jul 10, 2024
| if err := c.prepareRoutes(ctx, routeFile); err != nil { | ||
| return fmt.Errorf("failed to prepare routes: %w", err) | ||
| if err := c.prepareEnvoyTests(ctx); err != nil { | ||
| return fmt.Errorf("failed to prepare tests: %w", err) |
There was a problem hiding this comment.
Would be good to specify envoy tests here, as the error is the same on l88
Smeb
reviewed
Jul 10, 2024
Smeb
reviewed
Jul 10, 2024
Smeb
reviewed
Jul 10, 2024
Smeb
reviewed
Jul 10, 2024
Smeb
reviewed
Jul 10, 2024
Smeb
reviewed
Jul 10, 2024
Smeb
reviewed
Jul 10, 2024
Signed-off-by: Fernando Cainelli <[email protected]>
Signed-off-by: Fernando Cainelli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.