Experimental: istio-router-check tool #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fernando Cainelli <[email protected]>
Signed-off-by: Fernando Cainelli <[email protected]>
Signed-off-by: Fernando Cainelli <[email protected]>
Signed-off-by: Fernando Cainelli <[email protected]>
cainelli
changed the title
Signed-off-by: Fernando Cainelli <[email protected]>
Smeb
reviewed
Jun 28, 2024
Smeb
reviewed
Jun 28, 2024
Smeb
reviewed
Jun 28, 2024
Smeb
reviewed
Jun 28, 2024
Smeb
reviewed
Jun 28, 2024
Comment on lines
+95
to
+98
| out, err := routerCheck.CombinedOutput() | ||
| if err != nil { | ||
| return fmt.Errorf("%s", out) | ||
| } |
There was a problem hiding this comment.
Here we don't emit the error at all to the user - is that intended?
There was a problem hiding this comment.
cobra itself will show the error to the user, if we print here it would show the error twice.
There was a problem hiding this comment.
I mean that the actual value of err (that we check as err != nil) is not returned.
Smeb
reviewed
Jun 28, 2024
Smeb
reviewed
Jun 28, 2024
| return nil, fmt.Errorf("failed to generate routes: %w", err) | ||
| } | ||
| return rg.routes, nil | ||
| } |
There was a problem hiding this comment.
I think this would benefit from a high level comment describing overall what we're doing since it's a little intricate in terms of how it depends on the istio test framework.
Smeb
reviewed
Jun 28, 2024
Smeb
reviewed
Jun 28, 2024
Smeb
reviewed
Jun 28, 2024
Smeb
reviewed
Jun 28, 2024
Smeb
approved these changes
Jun 28, 2024
Signed-off-by: Fernando Cainelli <[email protected]>
… into router-check-tool Signed-off-by: Fernando Cainelli <[email protected]>
Signed-off-by: Fernando Cainelli <[email protected]>
Signed-off-by: Fernando Cainelli <[email protected]>
Signed-off-by: Fernando Cainelli <[email protected]>
Signed-off-by: Fernando Cainelli <[email protected]>
Signed-off-by: Fernando Cainelli <[email protected]>
Signed-off-by: Fernando Cainelli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First work towards envoy router check tool.