This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
Update Repo Documentation, archive older components, CI e2e tests #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add hardhat integration tests to github actions run. Add/update numerous READMEs for packages. Deprecate remaining ZKEmail recovery modules in favor of new one. Remove circom submodule. Increase wait time for plugins test servers.
jacque006
force-pushed
the
update-repo-docs
branch
from
97b8058 to
9d0c4cc
Compare
Update plugins README. Wrap deploy_all script's wallet with nonce manager.
jacque006
force-pushed
the
update-repo-docs
branch
from
b004267 to
baa419b
Compare
jacque006
changed the title
JohnGuilding
approved these changes
Jul 20, 2024
There was a problem hiding this comment.
Look great, merging then can make any further changes in follow ups :)
- Do you think we should get rid of the sdk?
- I'm still skeptical the joint foundry and hardhat project is a good setup for contributions, what do you think about breaking it up or changing something there?
- What do you think about splitting more things into different repos in further updates? I've been leaning against the monorepo pattern for wax, as not sure if it's giving us any big benefits, and makes it more difficult for people to understand what is going on in the repo
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
archivedirectoryHow can these changes be manually tested?
👀 , GitHub Actions CI pipeline should handle the rest
Does this PR resolve or contribute to any issues?
Resolves #211
Checklist
Guidelines
resolve conversationbutton is for reviewers, not authorsTODO