Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add romm #2020

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

mateosilguero
Copy link
Contributor

@mateosilguero mateosilguero commented Jan 7, 2025

App Submission

romm

romm (Rom Manager) is a web based retro roms manager integrated with IGDB. Also it has an embebed emulator

256x256 SVG icon
https://raw.githubusercontent.com/zurdi15/romm/a700aa98429b0ec96ec8d9d32ffa01c989d3569f/romm.svg

Gallery images
Captura de pantalla 2023-08-29 a la(s) 09 43 19

I have tested my app on:
Umbrel dev environment
Umbrel OS on a Raspberry Pi 4
Custom Umbrel install on Linux

Copy link

github-actions bot commented Jan 7, 2025

❌   Linting failed with 2 errors and 2 warnings   ❌

Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store.

Please review the linting results below and make any necessary changes to your submission.

Linting Results

Severity File Description
romm/docker-compose.yml Invalid image name "mariadb:latest":
Images should be named like "<name>:<version-tag>@<sha256>"
ℹ️ romm/docker-compose.yml Mounted file/directory "/romm/data/resources" doesn't exist:
The volume "${APP_DATA_DIR}/data/resources:/romm/resources" tries to mount the file/directory "/romm/data/resources", but it is not present. This can lead to permission errors!
ℹ️ romm/docker-compose.yml Mounted file/directory "/romm/data/redis" doesn't exist:
The volume "${APP_DATA_DIR}/data/redis:/redis-data" tries to mount the file/directory "/romm/data/redis", but it is not present. This can lead to permission errors!
ℹ️ romm/docker-compose.yml Mounted file/directory "/romm/data/library" doesn't exist:
The volume "${APP_DATA_DIR}/data/library:/romm/library" tries to mount the file/directory "/romm/data/library", but it is not present. This can lead to permission errors!
ℹ️ romm/docker-compose.yml Mounted file/directory "/romm/data/assets" doesn't exist:
The volume "${APP_DATA_DIR}/data/assets:/romm/assets" tries to mount the file/directory "/romm/data/assets", but it is not present. This can lead to permission errors!
ℹ️ romm/docker-compose.yml Mounted file/directory "/romm/data/config" doesn't exist:
The volume "${APP_DATA_DIR}/data/config:/romm/config" tries to mount the file/directory "/romm/data/config", but it is not present. This can lead to permission errors!
ℹ️ romm/docker-compose.yml Mounted file/directory "/romm/data/mysql" doesn't exist:
The volume "${APP_DATA_DIR}/data/mysql:/var/lib/mysql" tries to mount the file/directory "/romm/data/mysql", but it is not present. This can lead to permission errors!
ℹ️ romm/docker-compose.yml Potentially using unsafe user in service "server":
The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000.
ℹ️ romm/docker-compose.yml Potentially using unsafe user in service "romm-db":
The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000.
⚠️ romm/docker-compose.yml Invalid restart policy:
The restart policy of the container "romm-db" should be set to "on-failure".
romm/umbrel-app.yml releaseNotes:
Expected string, received null
⚠️ romm/umbrel-app.yml "icon" and "gallery" needs to be empty for new app submissions:
The "icon" and "gallery" fields must be empty for new app submissions as it is being created by the Umbrel team.

Legend

Symbol Description
Error: This must be resolved before this PR can be merged.
⚠️ Warning: This is highly encouraged to be resolved, but is not strictly mandatory.
ℹ️ Info: This is just for your information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant