Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[METUBE] delete files from disk #1927

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Conversation

MontejoJorge
Copy link
Contributor

@MontejoJorge MontejoJorge commented Dec 15, 2024

Add variable to delete files from disk when deleting from web ui

https://github.com/alexta69/metube?tab=readme-ov-file#configuration-via-environment-variables

Copy link

🎉   Linting finished with no errors or warnings   🎉

Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store.

Please review the linting results below and make any necessary changes to your submission.

Linting Results

Severity File Description
ℹ️ metube/docker-compose.yml Potentially using unsafe user in service "metube":
The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000.

Legend

Symbol Description
Error: This must be resolved before this PR can be merged.
⚠️ Warning: This is highly encouraged to be resolved, but is not strictly mandatory.
ℹ️ Info: This is just for your information.

@nmfretz
Copy link
Contributor

nmfretz commented Dec 17, 2024

Thanks for this @MontejoJorge. I've been on-the-fence about whether or not to include this env var in the past.

On one hand, the Completed section is kind of just a "downloads history" for videos. The videos are stored in a user's main storage directory on their Umbrel and not in an app directory: /home/umbrel/umbrel/data/storage/downloads/metube. So originally I thought it might be a bit weird to delete the videos permanently with MeTube since you can use the File Browser app to handle all files in Umbrel's main storage... kind of like how most torrent clients work.

But on the other hand, I've seen a few requests now from users who want this functionality within MeTube so let's change it!

I've update MeTube and added a note about the change in the release notes. I've reviewed and tested.

@nmfretz nmfretz merged commit cc223b6 into getumbrel:master Dec 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants