Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Elements Core to v23.2.4 & PeerSwap to v4rc2 #1926

Merged
merged 6 commits into from
Dec 31, 2024

Conversation

Impa10r
Copy link
Contributor

@Impa10r Impa10r commented Dec 14, 2024

Enables discounted Confidential Transactions on mainnet

@Impa10r Impa10r changed the title Update Elements Core to v23.2.4 Update Elements Core to v23.2.4 & PeerSwap to v4rc2 Dec 15, 2024
@nmfretz
Copy link
Contributor

nmfretz commented Dec 17, 2024

Excellent, thanks @Impa10r. I'm just syncing elements so I can test properly

Copy link

🎉   Linting finished with no errors or warnings   🎉

Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store.

Please review the linting results below and make any necessary changes to your submission.

Linting Results

Severity File Description
ℹ️ elements/docker-compose.yml Mounted file/directory "/elements/torrc" doesn't exist:
The volume "${APP_DATA_DIR}/torrc:/etc/tor/torrc:ro" tries to mount the file/directory "/elements/torrc", but it is not present. This can lead to permission errors!
ℹ️ elements/docker-compose.yml External port mapping "$APP_ELEMENTS_NODE_RPC_PORT:$APP_ELEMENTS_NODE_RPC_PORT":
Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).
ℹ️ elements/docker-compose.yml External port mapping "$APP_ELEMENTS_NODE_P2P_PORT:$APP_ELEMENTS_NODE_P2P_PORT":
Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).

Legend

Symbol Description
Error: This must be resolved before this PR can be merged.
⚠️ Warning: This is highly encouraged to be resolved, but is not strictly mandatory.
ℹ️ Info: This is just for your information.

@nmfretz
Copy link
Contributor

nmfretz commented Dec 31, 2024

Thanks again for these updates @Impa10r. I have tested and they are working well.

For our records: the user changes in 9aa4164 to satisfy the linter for the elements app are okay to do in this case. The ghcr.io/vulpemventures/elements image was already running as user 1000 so there are no permissions issues to handle for users who update:
https://github.com/vulpemventures/docker-elements/blob/170f26627eb51ed79c3790a58a3a053245015bc2/23.2.4/Dockerfile#L19-L31

And for the ghcr.io/tiero/elements-web that was previously running as root, there appears to be no data dir that it requires root permissions for.

@nmfretz nmfretz merged commit 18dbb01 into getumbrel:master Dec 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants