Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new debian based image #1905

Merged
merged 1 commit into from
Dec 9, 2024
Merged

new debian based image #1905

merged 1 commit into from
Dec 9, 2024

Conversation

Retropex
Copy link

@Retropex Retropex commented Dec 8, 2024

Forgot to push the Debian based image with curl for the datum release. 🤦‍♂️

Copy link

github-actions bot commented Dec 8, 2024

⚠️   Linting finished with 1 warning   ⚠️

Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store.

Please review the linting results below and make any necessary changes to your submission.

Linting Results

Severity File Description
ℹ️ bitcoin-knots/docker-compose.yml Mounted file/directory "/bitcoin-knots/torrc" doesn't exist:
The volume "${APP_DATA_DIR}/torrc:/etc/tor/torrc:ro" tries to mount the file/directory "/bitcoin-knots/torrc", but it is not present. This can lead to permission errors!
ℹ️ bitcoin-knots/docker-compose.yml External port mapping "${APP_BITCOIN_KNOTS_P2P_PORT}:${APP_BITCOIN_KNOTS_INTERNAL_P2P_PORT}":
Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).
ℹ️ bitcoin-knots/docker-compose.yml External port mapping "${APP_BITCOIN_KNOTS_RPC_PORT}:${APP_BITCOIN_KNOTS_INTERNAL_RPC_PORT}":
Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).
ℹ️ bitcoin-knots/docker-compose.yml Potentially using unsafe user in service "server":
The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000.
ℹ️ bitcoin-knots/docker-compose.yml Potentially using unsafe user in service "bitcoind":
The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000.
ℹ️ bitcoin-knots/docker-compose.yml Using unsafe user "root" in service "i2pd_daemon":
The user "root" can lead to security vulnerabilities. If possible please use a non-root user instead.
⚠️ bitcoin-knots/docker-compose.yml Invalid restart policy:
The restart policy of the container "bitcoind" should be set to "on-failure".

Legend

Symbol Description
Error: This must be resolved before this PR can be merged.
⚠️ Warning: This is highly encouraged to be resolved, but is not strictly mandatory.
ℹ️ Info: This is just for your information.

@nmfretz
Copy link
Contributor

nmfretz commented Dec 9, 2024

Thanks for the fix @Retropex. Tested app update and that curl is available in the container.

$ sudo docker exec -it bitcoin-knots_bitcoind_1 curl -I https://example.com
HTTP/2 200
accept-ranges: bytes
age: 449672
cache-control: max-age=604800
content-type: text/html; charset=UTF-8
date: Mon, 09 Dec 2024 11:37:25 GMT
etag: "3147526947"
expires: Mon, 16 Dec 2024 11:37:25 GMT
last-modified: Thu, 17 Oct 2019 07:18:26 GMT
server: ECAcc (lac/55BE)
x-cache: HIT
content-length: 1256

@nmfretz nmfretz merged commit 3539858 into getumbrel:master Dec 9, 2024
1 check passed
@Retropex Retropex deleted the newcontainer branch December 9, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants