App Submission: LinkStack - Self-hosted open-source Linktree alternative #1537

dennysubke · 2024-09-25T11:13:27Z

App Submission

LinkStack - Self-hosted open-source Linktree alternative

...

Icon

(unfortunately only png 😔)
...

Gallery images

I have tested my app on:

umbrelOS on a Raspberry Pi
umbrelOS on an Umbrel Home
umbrelOS on Linux VM

App Submission: LinkStack - Self-hosted open-source Linktree alternative

nmfretz · 2024-10-03T04:27:46Z

Thanks for submitting LinkStack @dennysubke! (and for your continued work on making sure Nexcloud is functioning correctly 🙏)

We've got our heads down on some other aspects of the codebase, but we have this on our radar and will get to it soon.

sharknoon

Thank you so much @dennysubke for your app submission! Really good work :)
I have left some suggestions below:

sharknoon · 2024-10-03T13:44:15Z

linkstack/docker-compose.yml

+
+  linkstack:
+    hostname: 'linkstack'
+    image: 'linkstackorg/linkstack:latest@sha256:abd691b4293b020a317de8794737671e0315159efcb868e8a4124d6f0611f7ae'


Adding a comment here makes it more clear why we are using the latest tag here

Suggested change

image: 'linkstackorg/linkstack:latest@sha256:abd691b4293b020a317de8794737671e0315159efcb868e8a4124d6f0611f7ae'

# This image has no version specific tags

image: 'linkstackorg/linkstack:latest@sha256:abd691b4293b020a317de8794737671e0315159efcb868e8a4124d6f0611f7ae'

sharknoon · 2024-10-03T13:50:03Z

linkstack/docker-compose.yml

+      LOG_LEVEL: 'info'
+      PHP_MEMORY_LIMIT: '256M'
+      UPLOAD_MAX_FILESIZE: '8M'


These values are already the default value, so we can omit them, see here.

Suggested change

LOG_LEVEL: 'info'

PHP_MEMORY_LIMIT: '256M'

UPLOAD_MAX_FILESIZE: '8M'

sharknoon · 2024-10-03T13:52:38Z

linkstack/docker-compose.yml

+    hostname: 'linkstack'
+    image: 'linkstackorg/linkstack:latest@sha256:abd691b4293b020a317de8794737671e0315159efcb868e8a4124d6f0611f7ae'
+    environment:
+      TZ: 'Europe/Berlin'


Unfortunately there is no environment variable from umbrelOS, that exposes the current timezone, so i suggest we go with the default value here (which is UTC)

Suggested change

TZ: 'Europe/Berlin'

sharknoon · 2024-10-03T13:56:59Z

linkstack/docker-compose.yml

+version: "3.8"
+
+services:
+


I have tested your app submission with this app proxy and it works. Note that we can skip the proxy auth, as this app has a built-in auth mechanism.

Suggested change

app_proxy:

environment:

APP_HOST: linkstack_linkstack_1

APP_PORT: 80

PROXY_AUTH_ADD: "false"

sharknoon · 2024-10-03T14:01:25Z

linkstack/docker-compose.yml

+
+
+# apache2 config problem not solved (work in progress)
+
+#version: "3.8"
+
+#services:
+#  app_proxy:
+#    environment:
+#      APP_HOST: denny-linkstack_web_1
+#      APP_PORT: 80
+
+#  web:
+#    image: linkstackorg/linkstack:latest@sha256:6e7e8f44099f7c4f1340bb9ffda5411f97da766a06fd63cf1ff90c57ce22dd61
+#    restart: on-failure
+#    volumes:
+#      - ${APP_DATA_DIR}/linkstack:/htdocs
+#    environment:
+#      HOST: umbrel.local    
+#      TZ: Europe/Berlin
+#      PHP_MEMORY_LIMIT: 512M
+#      UPLOAD_MAX_FILESIZE: 8M
+#      SERVER_ADMIN:
+#      HTTP_SERVER_NAME:
+#      HTTPS_SERVER_NAME:
+#      LOG_LEVEL: 'info'


As I have added the umbrelOS proxy, this can be removed

Suggested change

# apache2 config problem not solved (work in progress)

#version: "3.8"

#services:

# app_proxy:

# environment:

# APP_HOST: denny-linkstack_web_1

# APP_PORT: 80

# web:

# image: linkstackorg/linkstack:latest@sha256:6e7e8f44099f7c4f1340bb9ffda5411f97da766a06fd63cf1ff90c57ce22dd61

# restart: on-failure

# volumes:

# - ${APP_DATA_DIR}/linkstack:/htdocs

# environment:

# HOST: umbrel.local

# TZ: Europe/Berlin

# PHP_MEMORY_LIMIT: 512M

# UPLOAD_MAX_FILESIZE: 8M

# SERVER_ADMIN:

# HTTP_SERVER_NAME:

# HTTPS_SERVER_NAME:

# LOG_LEVEL: 'info'

sharknoon · 2024-10-03T14:06:42Z

linkstack/umbrel-app.yml

+port: 8190
+description: >-
+  LinkStack is a unique platform that provides an efficient solution for managing and sharing links online. Our platform offers a website similar to Linktree, which allows users to overcome the limitation of only being able to add one link on social media platforms.
+


One new line is missing

Suggested change

sharknoon · 2024-10-03T14:08:50Z

linkstack/umbrel-app.yml

+website: https://linkstack.org/
+submitter: dennysubke
+submission: https://github.com/getumbrel/umbrel-apps/pull/1537
+repo: https://github.com/linkstackorg/linkstack


Keep it the same as the support url. This is the original url:

Suggested change

repo: https://github.com/linkstackorg/linkstack

repo: https://github.com/LinkStackOrg/LinkStack

sharknoon · 2024-10-03T14:09:23Z

linkstack/umbrel-app.yml

+releaseNotes: >-
+


Can be shortened to this:

Suggested change

releaseNotes: >-

releaseNotes: ""

sharknoon · 2024-10-03T14:10:15Z

linkstack/umbrel-app.yml

+defaultUsername: ""
+defaultPassword: ""


Those two are not needed

Suggested change

defaultUsername: ""

defaultPassword: ""

sharknoon · 2024-10-03T14:21:29Z

linkstack/docker-compose.yml

+
+services:
+
+  linkstack:


Adding a comment indicating that this image doesn't support a custom user

Suggested change

linkstack:

linkstack:

# This image doesn't support a custom user

# user: '1000:1000'

I have now implemented all suggested changes. I hope everything is correct so far.

nmfretz · 2024-10-24T05:50:56Z

Hey @dennysubke, just a friendly ping to remind you about @sharknoon's review above.

dennysubke · 2024-10-24T08:53:48Z

Hey @dennysubke, just a friendly ping to remind you about @sharknoon's review above.

Done! Thanks for the reminder. :)

sharknoon

@dennysubke please also create a folder linkstack/data and a file called .gitkeep inside of it. The reason is, that we get permission errors otherwise, because docker creates the data folder for us with the wrong permissions, if we aren't creating it ourselves.

Otherwise this app looks good! Thank you for your work so far :)

sharknoon · 2024-10-24T09:09:45Z

linkstack/docker-compose.yml

+volumes:
+  linkstack_data:


As @nmfretz suggested, this is a workaround to not use named volumes, but mock them. Can you implement this and test it, if it works on your side? Thank you :)

Suggested change

volumes:

linkstack_data:

volumes:

linkstack_data:

driver: local

driver_opts:

o: bind

type: none

device: ${APP_DATA_DIR}/data

linkstack/docker-compose.yml

sharknoon · 2024-10-24T14:38:02Z

Thank you @dennysubke for your awesome submission.
@nmfretz this one looks good to me

nmfretz · 2024-10-25T00:45:40Z

Awesome, thanks guys.

@dennysubke before I do a final review/test, is this app working for you now?

dennysubke · 2024-10-25T05:35:29Z

@nmfretz Just tested it again, and it's working perfectly. Thanks for all the help! 👍

nmfretz · 2024-10-28T01:25:58Z

@nmfretz Just tested it again, and it's working perfectly. Thanks for all the help! 👍

Excellent, thanks @dennysubke. I have gone through and made some final changes (including removing unneeded environment variables) to finalize this dennysubke/umbrel-apps@71edf47...286fa6b

I have tested this and everything is working well for me, including configuring Cloudflare to expose linkstack.

We'll give a once-over on the icon and gallery images and then go live!

github-actions · 2024-11-04T07:03:17Z

⚠️ Linting finished with 2 warnings ⚠️

Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store.

Please review the linting results below and make any necessary changes to your submission.

Linting Results

Severity	File	Description
⚠️	`linkstack/docker-compose.yml`	Invalid image tag "latest": Images should not use the "latest" tag
ℹ️	`linkstack/docker-compose.yml`	Potentially using unsafe user in service "linkstack": The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000.
⚠️	`linkstack/umbrel-app.yml`	"icon" and "gallery" needs to be empty for new app submissions: The "icon" and "gallery" fields must be empty for new app submissions as it is being created by the Umbrel team.

Legend

Symbol	Description
❌	Error: This must be resolved before this PR can be merged.
⚠️	Warning: This is highly encouraged to be resolved, but is not strictly mandatory.
ℹ️	Info: This is just for your information.

nmfretz · 2024-11-04T07:03:42Z

Thanks again for your work on LinkStak @dennysubke! We are going live.

dennysubke · 2024-11-04T20:42:23Z

@nmfretz @sharknoon Thank you for the great work and your constant efforts! Please take a look at my Umbrel Community AppStore when you get the chance:

https://github.com/dennysubke/dennys-umbrel-app-store

Maybe there's something there... 😎

dennysubke added 15 commits September 24, 2024 22:31

Merge pull request #1 from getumbrel/master

8cbd8c6

App Submission: LinkStack - Self-hosted open-source Linktree alternative

Add files via upload

1679c67

Delete denny-linkstack directory

b8cd858

Add files via upload

98bbed6

Update docker-compose.yml

34dce5d

Update umbrel-app.yml

c3c6fdb

Update umbrel-app.yml

8a30866

Update umbrel-app.yml

2c1669f

Update umbrel-app.yml

8855afa

Update umbrel-app.yml

7fb6b12

Update umbrel-app.yml

a467b93

Update umbrel-app.yml

627d78b

Add files via upload

57d703f

Delete excalidraw directory

5c5ebcc

Update umbrel-app.yml

c4d4543

sharknoon suggested changes Oct 3, 2024

View reviewed changes

dennysubke added 2 commits October 24, 2024 10:45

Update docker-compose.yml

33333a4

Update umbrel-app.yml

0595913

sharknoon suggested changes Oct 24, 2024

View reviewed changes

dennysubke added 6 commits October 24, 2024 13:52

Add files via upload

7d39699

Rename gitkeep to .gitkeep

0299512

Delete linkstack/linkstack/data directory

e4b4fb6

Add files via upload

c16914a

Rename gitkeep to .gitkeep

c8c4ce2

Update docker-compose.yml

71edf47

nmfretz added 7 commits October 28, 2024 10:37

Update compose comments

84ebf26

Remove unused env vars

8dc8d92

Remove env vars entirely

b85ffc4

Set gallery images

cab9e3c

remove icon from manifest

e540c33

Remove blank line from manifest

9d891ad

Move and reword cloudflare suggestion in app description

fbea9e4

getumbrel deleted a comment from github-actions bot Oct 28, 2024

Change compose yaml version to 3.7

286fa6b

getumbrel deleted a comment from github-actions bot Oct 28, 2024

shorten tagline

7cecd5d

nmfretz merged commit 1fcde88 into getumbrel:master Nov 4, 2024
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

App Submission: LinkStack - Self-hosted open-source Linktree alternative #1537

App Submission: LinkStack - Self-hosted open-source Linktree alternative #1537

dennysubke commented Sep 25, 2024

nmfretz commented Oct 3, 2024

sharknoon left a comment

sharknoon Oct 3, 2024

sharknoon Oct 3, 2024

sharknoon Oct 3, 2024

sharknoon Oct 3, 2024

sharknoon Oct 3, 2024

sharknoon Oct 3, 2024

sharknoon Oct 3, 2024

sharknoon Oct 3, 2024

sharknoon Oct 3, 2024

sharknoon Oct 3, 2024

dennysubke Oct 24, 2024

nmfretz commented Oct 24, 2024

dennysubke commented Oct 24, 2024

sharknoon left a comment

sharknoon Oct 24, 2024

dennysubke Oct 24, 2024

sharknoon commented Oct 24, 2024

nmfretz commented Oct 25, 2024

dennysubke commented Oct 25, 2024

nmfretz commented Oct 28, 2024 •

edited

Loading

github-actions bot commented Nov 4, 2024

nmfretz commented Nov 4, 2024

dennysubke commented Nov 4, 2024

	LOG_LEVEL: 'info'
	PHP_MEMORY_LIMIT: '256M'
	UPLOAD_MAX_FILESIZE: '8M'

	repo: https://github.com/linkstackorg/linkstack
	repo: https://github.com/LinkStackOrg/LinkStack

		version: "3.8"

		services:


		services:

		linkstack:

App Submission: LinkStack - Self-hosted open-source Linktree alternative #1537

App Submission: LinkStack - Self-hosted open-source Linktree alternative #1537

Conversation

dennysubke commented Sep 25, 2024

App Submission

LinkStack - Self-hosted open-source Linktree alternative

Icon

Gallery images

I have tested my app on:

nmfretz commented Oct 3, 2024

sharknoon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nmfretz commented Oct 24, 2024

dennysubke commented Oct 24, 2024

sharknoon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sharknoon commented Oct 24, 2024

nmfretz commented Oct 25, 2024

dennysubke commented Oct 25, 2024

nmfretz commented Oct 28, 2024 • edited Loading

github-actions bot commented Nov 4, 2024

⚠️ Linting finished with 2 warnings ⚠️

Linting Results

Legend

nmfretz commented Nov 4, 2024

dennysubke commented Nov 4, 2024

nmfretz commented Oct 28, 2024 •

edited

Loading