Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump LNBits to 0.12.10 #1328

Closed
wants to merge 2 commits into from
Closed

Bump LNBits to 0.12.10 #1328

wants to merge 2 commits into from

Conversation

mroxso
Copy link

@mroxso mroxso commented Aug 11, 2024

This bumps LNBits to the latest version

Copy link

❌   Linting failed with 1 error   ❌

Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store.

Please review the linting results below and make any necessary changes to your submission.

Linting Results

Severity File Description
lnbits/docker-compose.yml Invalid image architectures for image "lnbits/lnbits:0.12.10@sha256:a78cd96e1630895160b2878e8fcf17a36e5f3de532d4c4b849f103a34a8a0841":
The image "lnbits/lnbits:0.12.10@sha256:a78cd96e1630895160b2878e8fcf17a36e5f3de532d4c4b849f103a34a8a0841" does not support the architectures "arm64" and "amd64". Please make sure that the image supports both architectures.
ℹ️ lnbits/docker-compose.yml Potentially using unsafe user in service "web":
The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000.

Legend

Symbol Description
Error: This must be resolved before this PR can be merged.
⚠️ Warning: This is highly encouraged to be resolved, but is not strictly mandatory.
ℹ️ Info: This is just for your information.

@nmfretz
Copy link
Contributor

nmfretz commented Aug 14, 2024

Thanks for this update of LNBits @mroxso!

There's a few things we need to do before merging to the app store:

  1. Use the multi-arch digest for lnbits Docker image so that both x86(amd64) and arm64 users are supported. Right now, the image digest used is only for linux/amd64, so arm64 users who attempt to install/update LNbits will end up with a broken install.

  2. Add release notes details to umbrel-app.yml

  3. Test the app to make sure fresh installs work and that data is persisted for app updates (e.g., we need to make sure users will not lose funds).

Would you like to take the lead on this, or would you be okay with me pushing changes to your branch?

@nmfretz
Copy link
Contributor

nmfretz commented Aug 28, 2024

Thanks again for this PR @mroxso. I am closing this in favour of this one here where I have asked the LNbits team for advice on the update: #1370

@nmfretz nmfretz closed this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants