Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BTC RPC Explorer with RPC Terminal Functionality #1319

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

nmfretz
Copy link
Contributor

@nmfretz nmfretz commented Aug 7, 2024

This PR adds RPC Terminal and RPC Browser functionality to BTC RPC Explorer. This is done by enabling password protection with a non-empty BTCEXP_BASIC_AUTH_PASSWORD environment variable.

Closes #569

The app only requires a password and no username, per https://github.com/janoside/btc-rpc-explorer/blob/adb80713ffea2a39fb600a3e61348dbd207bba52/.env-sample#L116-L118

...but the browser popup auth asks for both a username and password, so to avoid unnecessary confusion and instructions in the app-description to leave the username blank, I have just included a default username.

image

Copy link

github-actions bot commented Aug 7, 2024

🎉   Linting finished with no errors or warnings   🎉

Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store.

Please review the linting results below and make any necessary changes to your submission.

Linting Results

Severity File Description
ℹ️ btc-rpc-explorer/docker-compose.yml Potentially using unsafe user in service "web":
The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000.

Legend

Symbol Description
Error: This must be resolved before this PR can be merged.
⚠️ Warning: This is highly encouraged to be resolved, but is not strictly mandatory.
ℹ️ Info: This is just for your information.

@nmfretz nmfretz merged commit 4835549 into master Aug 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BTC RPC Explorer app - RPC terminal do not login
1 participant