Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update samba to version v4.20.2 #1318

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Update samba to version v4.20.2 #1318

merged 2 commits into from
Sep 12, 2024

Conversation

nmfretz
Copy link
Contributor

@nmfretz nmfretz commented Aug 7, 2024

This is an automated pull request to update samba to version v4.20.2. This PR must be reviewed and tested before merging.

@nmfretz
Copy link
Contributor Author

nmfretz commented Aug 7, 2024

Copy link

github-actions bot commented Aug 7, 2024

🎉   Linting finished with no errors or warnings   🎉

Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store.

Please review the linting results below and make any necessary changes to your submission.

Linting Results

Severity File Description
ℹ️ samba/docker-compose.yml External port mapping "446:445":
Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).

Legend

Symbol Description
Error: This must be resolved before this PR can be merged.
⚠️ Warning: This is highly encouraged to be resolved, but is not strictly mandatory.
ℹ️ Info: This is just for your information.

@nmfretz
Copy link
Contributor Author

nmfretz commented Aug 11, 2024

Awaiting #1161 (comment)

@nmfretz
Copy link
Contributor Author

nmfretz commented Aug 29, 2024

@joaovictor-local, pinging you just in case you haven't seen this comment by @sharknoon here: #1161 (comment)

@nmfretz
Copy link
Contributor Author

nmfretz commented Sep 12, 2024

@joaovictor-local @sharknoon I am going to update Samba for now and we can revisit updating the UI in the next release.

@nmfretz nmfretz merged commit b8d6bfa into master Sep 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant