Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Nextcloud to v29.0.4 #1297

Merged
merged 6 commits into from
Aug 6, 2024
Merged

Update Nextcloud to v29.0.4 #1297

merged 6 commits into from
Aug 6, 2024

Conversation

nmfretz
Copy link
Contributor

@nmfretz nmfretz commented Aug 6, 2024

This is a major upgrade from version 28.0.3 to 29.0.4. The Nextcloud app on the Umbrel app store will now receive updates in alignment with the official Nextcloud release schedule moving forward.

  • For new installs: added the nextcloud web container name to theNEXTCLOUD_TRUSTED_DOMAINS env var so that apps like ONLYOFFICE Docs can communicate via Docker dns
  • For existing installs: added a post-update hook that adds the nextcloud web container name to trusted_domains in config.php.

Tested fresh install and update.

Copy link

github-actions bot commented Aug 6, 2024

🎉   Linting finished with no errors or warnings   🎉

Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store.

Please review the linting results below and make any necessary changes to your submission.

Linting Results

Severity File Description
ℹ️ nextcloud/docker-compose.yml Potentially using unsafe user in service "web":
The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000.
ℹ️ nextcloud/docker-compose.yml Potentially using unsafe user in service "cron":
The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000.

Legend

Symbol Description
Error: This must be resolved before this PR can be merged.
⚠️ Warning: This is highly encouraged to be resolved, but is not strictly mandatory.
ℹ️ Info: This is just for your information.

@nmfretz nmfretz merged commit cee2764 into master Aug 6, 2024
1 check passed
@dennysubke
Copy link
Contributor

dennysubke commented Aug 6, 2024

Thanks for the update and the good work.

After the update I get the following error messages:

  • Your data directory and files are probably accessible from the Internet. The .htaccess file is not working. It is strongly recommended that you configure your web server so that the data directory is no longer accessible from the Internet or that you move it out of the document root directory of the web server.

  • Your "trusted_proxies" setting is not set correctly, it should be an array of IP addresses - optionally with a range in CIDR notation. You can find more information in the documentation.

I use Cloudflare and have already entered all IP address ranges in the Config.php under Trusted Proxies. Any ideas?

@nmfretz
Copy link
Contributor Author

nmfretz commented Aug 7, 2024

Thanks for reporting and reaching out @dennysubke. Both of these error messages are likely related to the trusted_proxies array in the config.php file. It seems to be a pretty common Nextcloud issue in v29 from looking at this thread: https://help.nextcloud.com/t/after-upgrade-from-28-to-29-i-have-data-directory-and-your-files-are-probably-accessible-from-the-internet/189882/42

Is there anything in there that helps explain your situation?

@nmfretz
Copy link
Contributor Author

nmfretz commented Aug 9, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants