Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Bitcoin Knots to v27.1.knots20240801 #1295

Merged
merged 1 commit into from
Aug 4, 2024
Merged

Update Bitcoin Knots to v27.1.knots20240801 #1295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bitcoin-knots/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
version: "3.7"

Check notice on line 1 in bitcoin-knots/docker-compose.yml

View workflow job for this annotation

GitHub Actions / Lint apps

Potentially using unsafe user in service "server" 

The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000.

Check notice on line 1 in bitcoin-knots/docker-compose.yml

View workflow job for this annotation

GitHub Actions / Lint apps

Potentially using unsafe user in service "bitcoind" 

The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000.

services:
app_proxy:
Expand Down Expand Up @@ -41,13 +41,13 @@
ipv4_address: $APP_BITCOIN_KNOTS_IP

bitcoind:
image: retropexx/bitcoind:v27.1@sha256:4b405d9aca9d5b37a70cfa397f87df490a3f3452885d7bc80d1d1a6b110b06b5
image: retropexx/bitcoind:v27.2@sha256:d8519754120133324c54a9c638a5da63580a4581c9671190613db0de01e0da4b
command: "${APP_BITCOIN_KNOTS_COMMAND}"
restart: unless-stopped
stop_grace_period: 15m30s
volumes:
- "${APP_BITCOIN_KNOTS_DATA_DIR}:/data/.bitcoin"
ports:

Check notice on line 50 in bitcoin-knots/docker-compose.yml

View workflow job for this annotation

GitHub Actions / Lint apps

External port mapping "${APP_BITCOIN_KNOTS_P2P_PORT}:${APP_BITCOIN_KNOTS_INTERNAL_P2P_PORT}" 

Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).

Check notice on line 50 in bitcoin-knots/docker-compose.yml

View workflow job for this annotation

GitHub Actions / Lint apps

External port mapping "${APP_BITCOIN_KNOTS_RPC_PORT}:${APP_BITCOIN_KNOTS_INTERNAL_RPC_PORT}" 

Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).
- "${APP_BITCOIN_KNOTS_P2P_PORT}:${APP_BITCOIN_KNOTS_INTERNAL_P2P_PORT}"
- "${APP_BITCOIN_KNOTS_RPC_PORT}:${APP_BITCOIN_KNOTS_INTERNAL_RPC_PORT}"
networks:
Expand All @@ -58,7 +58,7 @@
image: getumbrel/tor:0.4.7.8@sha256:2ace83f22501f58857fa9b403009f595137fa2e7986c4fda79d82a8119072b6a
user: "1000:1000"
restart: on-failure
volumes:

Check notice on line 61 in bitcoin-knots/docker-compose.yml

View workflow job for this annotation

GitHub Actions / Lint apps

Mounted file/directory "/bitcoin-knots/torrc" doesn't exist 

The volume "${APP_DATA_DIR}/torrc:/etc/tor/torrc:ro" tries to mount the file/directory "/bitcoin-knots/torrc", but it is not present. This can lead to permission errors!
- ${APP_DATA_DIR}/torrc:/etc/tor/torrc:ro
- ${TOR_DATA_DIR}:/data
environment:
Expand All @@ -69,7 +69,7 @@

i2pd_daemon:
image: purplei2p/i2pd:release-2.44.0@sha256:d154a599793c393cf9c91f8549ba7ece0bb40e5728e1813aa6dd4c210aa606f6
user: "root"

Check notice on line 72 in bitcoin-knots/docker-compose.yml

View workflow job for this annotation

GitHub Actions / Lint apps

Using unsafe user "root" in service "i2pd_daemon" 

The user "root" can lead to security vulnerabilities. If possible please use a non-root user instead.
command: --sam.enabled=true --sam.address=0.0.0.0 --sam.port=7656 --loglevel=error
restart: on-failure
volumes:
Expand Down
4 changes: 2 additions & 2 deletions bitcoin-knots/umbrel-app.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ manifestVersion: 1.1
id: bitcoin-knots
category: bitcoin
name: Bitcoin Knots
version: "27.1"
version: "27.1.1"
tagline: Run your personal node powered by Bitcoin Knots
description: >-
Take control of your digital sovereignty by running a Bitcoin node that aligns with your needs and preferences.
Expand Down Expand Up @@ -30,6 +30,6 @@ releaseNotes: >-
This release updates Bitcoin Knots to version 27.1


Full release notes for Bitcoin Knots can be found at https://github.com/bitcoinknots/bitcoin/releases/tag/v27.1.knots20240621
Full release notes can be found at https://github.com/bitcoinknots/bitcoin/releases/tag/v27.1.knots20240801
submitter: Léo Haf
submission: https://github.com/getumbrel/umbrel-apps/pull/953