-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App Submission: Navidrome #1232
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for your awesome app submission @owmsoton! I have left you some suggestions below:
Co-authored-by: Josua Frank <[email protected]>
Co-authored-by: Josua Frank <[email protected]>
Co-authored-by: Josua Frank <[email protected]>
Co-authored-by: Josua Frank <[email protected]>
Co-authored-by: Josua Frank <[email protected]>
Co-authored-by: Josua Frank <[email protected]>
@sharknoon Thank you for all your help! All your suggestions were very helpful and I learned a lot. I ended up improving some details and I believe the corrections were well applied. I look forward to the next steps. Thanks again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome update @owmsoton! You really made a lot of great changes :) I have left 3 suggestions below, after that I think we are ready to go :)
Co-authored-by: Josua Frank <[email protected]>
Co-authored-by: Josua Frank <[email protected]>
@sharknoon, Just a few small tweaks, but in the end, they make a huge difference for everyone. Thanks again! |
Excellent, thanks for this submission @owmsoton! And for the excellent review @sharknoon. We will get gallery assets prepared and then test the app before going live. I noticed one minor change we can make: In the - ${UMBREL_ROOT}/data/storage/music:/music And then in the umbrel-app.yml we need to add the following for proper permissions to permissions:
- STORAGE_DOWNLOADS See Plex for example: https://github.com/getumbrel/umbrel-apps/blob/master/plex/umbrel-app.yml Can you please make this change and let us know if Navidrome is working correctly? |
@nmfretz Application working perfectly with your management. Thanks to everyone for the help and guidance. |
🎉 Linting finished with no errors or warnings 🎉Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store. |
Thanks again for this submission @owmsoton! I have tested and made some final tweaks. The biggest change is that I have changed the bind mount for the music folder on the host such that it is the same folder used by other music apps in the umbrelOS app store. This means, for example, that you can download music files with Lidarr and they will automatically appear in Navidrome. Gallery assets: https://github.com/getumbrel/umbrel-apps-gallery/tree/master/navidrome Going live to the app store 🎉🎧 |
App Submission
App name
Navidrome
256x256 SVG icon
Gallery images
I have tested my app on: