Skip to content

Commit

Permalink
added onlyoffice to this branch
Browse files Browse the repository at this point in the history
  • Loading branch information
a4004 committed Aug 5, 2024
1 parent a270829 commit 952043b
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 10 deletions.
8 changes: 4 additions & 4 deletions onlyoffice-nextcloud/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,17 +9,17 @@ services:
image: a4004/onlyoffice-nextcloud-web:1.0.4@sha256:774bd9bda641e6be49286921637840efba050fdfd022934dfd9ee9b6ec8d0a63
restart: on-failure
environment:
- DOCS_ADDRESS=http://$DEFAULT_INTERFACE_IP:$DOCSERVER_PORT
- DOCS_INTERNAL_ADDRESS=http://$DEFAULT_INTERFACE_IP:$DOCSERVER_PORT
- NEXTCLOUD_INTERNAL_ADDRESS=http://$DOCKER_INTERFACE_IP:$APP_NEXTCLOUD_PORT
- DOCS_ADDRESS=http://$DEVICE_DOMAIN_NAME:$DOCSERVER_PORT
- DOCS_INTERNAL_ADDRESS=http://onlyoffice-nextcloud_documentserver_1
- NEXTCLOUD_INTERNAL_ADDRESS=http://$GATEWAY_IP:$APP_NEXTCLOUD_PORT
- NEXTCLOUD_WEB_URL=http://$DEVICE_DOMAIN_NAME:$APP_NEXTCLOUD_PORT

documentserver:
image: onlyoffice/documentserver:8.1@sha256:9b74cb0e05580bced87f9af69de68d5f4c9e5b3340448ddc94333f5f7f4eba85
restart: on-failure
stop_grace_period: 1m
ports:

Check notice on line 21 in onlyoffice-nextcloud/docker-compose.yml

View workflow job for this annotation

GitHub Actions / Lint apps

External port mapping "${DOCSERVER_PORT}:80"

Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).
- 5672:80
- "${DOCSERVER_PORT}:80"
environment:
- JWT_ENABLED=false
- ONLYOFFICE_HTTPS_HSTS_ENABLED=false
Expand Down
6 changes: 1 addition & 5 deletions onlyoffice-nextcloud/exports.sh
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
#!/usr/bin/env bash

export DOCSERVER_PORT=5672
export APP_DOCSERVER_PORT=3014

export DEFAULT_INTERFACE_IP=$(ip addr show $(ip route | grep default | awk '{print $5}') | grep 'inet ' | awk '{print $2}' | cut -d/ -f1)
export DOCKER_INTERFACE_IP=$(ip addr show docker0 | grep 'inet ' | awk '{print $2}' | cut -d/ -f1)
export DOCSERVER_PORT=5672
2 changes: 1 addition & 1 deletion onlyoffice-nextcloud/umbrel-app.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
manifestVersion: 1
id: onlyoffice-nextcloud
category: files
name: ONLYOFFICE Document Server
name: ONLYOFFICE Docs
version: "8.1"
tagline: Run your private office with the ONLYOFFICE
description: >-
Expand Down

0 comments on commit 952043b

Please sign in to comment.