Skip to content

Commit

Permalink
Update docker-compose.yml
Browse files Browse the repository at this point in the history
  • Loading branch information
@dennysubke
dennysubke authored Nov 21, 2024
1 parent 6d03c38 commit 8321fa3
Showing 1 changed file with 6 additions and 10 deletions.
16 changes: 6 additions & 10 deletions zoraxy/docker-compose.yml
View file
Original file line number Diff line number Diff line change
@@ -1,23 +1,19 @@
version: '3.7'

Check notice on line 1 in zoraxy/docker-compose.yml

View workflow job for this annotation

GitHub Actions / Lint apps

Potentially using unsafe user in service "server" 

The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000.

services:
app_proxy:
environment:
APP_HOST: zoraxy_server_1
APP_PORT: 8000
PROXY_AUTH_ADD: "false"
server:
image: zoraxydocker/zoraxy:v3.1.2@sha256:38f23c5a507542bbd6eac0492bf6456be2004015594ca270a1a5998c8a377b74
restart: on-failure
#ports: -> The proxy service is listening on port 8400
# 8480:80
# 8443:443
# 8400:8000
ports:

Check notice on line 11 in zoraxy/docker-compose.yml

View workflow job for this annotation

GitHub Actions / Lint apps

External port mapping "41080:80" 

Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).

Check notice on line 11 in zoraxy/docker-compose.yml

View workflow job for this annotation

GitHub Actions / Lint apps

External port mapping "41443:443" 

Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).
- 41080:80
- 41443:443
volumes:

Check notice on line 14 in zoraxy/docker-compose.yml

View workflow job for this annotation

GitHub Actions / Lint apps

Mounted file/directory "/zoraxy/data/config/" doesn't exist 

The volume "${APP_DATA_DIR}/data/config/:/opt/zoraxy/config" tries to mount the file/directory "/zoraxy/data/config/", but it is not present. This can lead to permission errors!
- ${APP_DATA_DIR}/config/:/opt/zoraxy/config/
# ${APP_DATA_DIR}/zerotier/config/:/var/lib/zerotier-one/ -> If you are not using ZeroTier, this directory is irrelevant.
- /var/run/docker.sock:/var/run/docker.sock
- ${APP_DATA_DIR}/data/config/:/opt/zoraxy/config
- /etc/localtime:/etc/localtime:ro
environment:
FASTGEOIP: "false"
ZEROTIER: "false"

#⚠️ Zoraxy setup is working fine, but without HTTPS and ZeroTier support.

0 comments on commit 8321fa3

Please sign in to comment.