Skip to content

Added bitcoind container 'user' parameter #1391

Added bitcoind container 'user' parameter

Added bitcoind container 'user' parameter #1391

Triggered via pull request January 7, 2025 00:32
@nmfretznmfretz
synchronize #1987
Status Success
Total duration 22s
Artifacts

lint-apps.yml

on: pull_request_target
Lint apps
12s
Lint apps
Fit to window
Zoom out
Zoom in

Annotations

2 warnings and 5 notices
Lint apps
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Invalid restart policy: bitcoin-knots/docker-compose.yml#L50
The restart policy of the container "bitcoind" should be set to "on-failure".
Mounted file/directory "/bitcoin-knots/torrc" doesn't exist: bitcoin-knots/docker-compose.yml#L65
The volume "${APP_DATA_DIR}/torrc:/etc/tor/torrc:ro" tries to mount the file/directory "/bitcoin-knots/torrc", but it is not present. This can lead to permission errors!
External port mapping "${APP_BITCOIN_KNOTS_P2P_PORT}:${APP_BITCOIN_KNOTS_INTERNAL_P2P_PORT}": bitcoin-knots/docker-compose.yml#L54
Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).
External port mapping "${APP_BITCOIN_KNOTS_RPC_PORT}:${APP_BITCOIN_KNOTS_INTERNAL_RPC_PORT}": bitcoin-knots/docker-compose.yml#L54
Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).
Potentially using unsafe user in service "server": bitcoin-knots/docker-compose.yml#L1
The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000.
Using unsafe user "root" in service "i2pd_daemon": bitcoin-knots/docker-compose.yml#L76
The user "root" can lead to security vulnerabilities. If possible please use a non-root user instead.