App submission mosquitto #1130
dirstelAnnotations
3 errors, 1 warning, and 6 notices
|
Invalid submission field "https://github.com/getumbrel/umbrel-apps/pull/###":
mosquitto/umbrel-app.yml#L20
The submission field must be set to the URL of this pull request: https://github.com/getumbrel/umbrel-apps/pull/1789
|
|
Port 9011 is already used by MinIO (minio):
mosquitto/umbrel-app.yml#L8
Each app must use a unique port
|
|
Lint apps
❌ Linting failed with 2 errors and 1 warning ❌
|
|
"icon" and "gallery" needs to be empty for new app submissions:
mosquitto/umbrel-app.yml#L5
The "icon" and "gallery" fields must be empty for new app submissions as it is being created by the Umbrel team.
|
|
Mounted file/directory "/mosquitto/config" doesn't exist:
mosquitto/docker-compose.yml#L13
The volume "${APP_DATA_DIR}/config:/mosquitto/config:rw" tries to mount the file/directory "/mosquitto/config", but it is not present. This can lead to permission errors!
|
|
Mounted file/directory "/mosquitto/log" doesn't exist:
mosquitto/docker-compose.yml#L13
The volume "${APP_DATA_DIR}/log:/mosquitto/log:rw" tries to mount the file/directory "/mosquitto/log", but it is not present. This can lead to permission errors!
|
|
Mounted file/directory "/mosquitto/www" doesn't exist:
mosquitto/docker-compose.yml#L13
The volume "${APP_DATA_DIR}/www:/mosquitto/www:r" tries to mount the file/directory "/mosquitto/www", but it is not present. This can lead to permission errors!
|
|
External port mapping "1883:1883":
mosquitto/docker-compose.yml#L10
Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).
|
|
External port mapping "9001:9001":
mosquitto/docker-compose.yml#L10
Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).
|
|
Potentially using unsafe user in service "broker":
mosquitto/docker-compose.yml#L1
The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000.
|