Skip to content

App Submission: NPM (Nginx Proxy Manager) #474

App Submission: NPM (Nginx Proxy Manager)

App Submission: NPM (Nginx Proxy Manager) #474

Triggered via pull request September 20, 2024 04:24
@sahilphsahilph
synchronize #1296
Status Success
Total duration 13s
Artifacts

lint-apps.yml

on: pull_request_target
Lint apps
4s
Lint apps
Fit to window
Zoom out
Zoom in

Annotations

1 warning and 4 notices
"icon" and "gallery" needs to be empty for new app submissions: nginx-proxy-manager/umbrel-app.yml#L5
The "icon" and "gallery" fields must be empty for new app submissions as it is being created by the Umbrel team.
Mounted file/directory "/nginx-proxy-manager/data/npm-data" doesn't exist: nginx-proxy-manager/docker-compose.yml#L15
The volume "${APP_DATA_DIR}/data/npm-data:/data" tries to mount the file/directory "/nginx-proxy-manager/data/npm-data", but it is not present. This can lead to permission errors!
Mounted file/directory "/nginx-proxy-manager/data/letsencrypt" doesn't exist: nginx-proxy-manager/docker-compose.yml#L15
The volume "${APP_DATA_DIR}/data/letsencrypt:/etc/letsencrypt" tries to mount the file/directory "/nginx-proxy-manager/data/letsencrypt", but it is not present. This can lead to permission errors!
External port mapping "40080:80": nginx-proxy-manager/docker-compose.yml#L12
Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).
External port mapping "40443:443": nginx-proxy-manager/docker-compose.yml#L12
Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).