Rebase PoetOS/moodle-mod_questionnaire:MOODLE_404_STABLE. to master #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
July 16, 2019 11:01
Co-authored-by: Emanoil Manoylov <[email protected]>
…el (#511) Co-authored-by: Emanoil Manoylov <[email protected]>
Signed-off-by: rezeau <[email protected]>
Signed-off-by: rezeau <[email protected]>
* Update sectiontext questions to display on mobile. Also refactored the code a bit for clarity: The question class now has an is_numbered() method (default true) that can be overridden for question types that should not have numbers. Replaced some checks for specific question types with checks for is_numbered(). * test: Fix PHPDoc for mobile_question_display
#520) * Add Slider question type compatibility with Feedback features for MOODLE_401_STABLE Signed-off-by: rezeau <[email protected]> * removed trailing spaces in slider_feedback_question_type.feature Signed-off-by: rezeau <[email protected]> --------- Signed-off-by: rezeau <[email protected]>
Co-authored-by: Matthias Opitz <[email protected]>
Co-authored-by: Emanoil Manoylov <[email protected]>
* Fixing Moodle Code Checker issues. * Prepare for Moodle 4.3.
Co-authored-by: toanlam <[email protected]>
* Mobile app: Create ionic5 templates duplicating latest * Mobile app: Remove ionic3 templates * Mobile app: Update questions templates to Ionic 7 * Mobile app: Stop using deprecated module-description
Update Behat tests replacing steps deprecated by MDL-79029.
Remove require_once() for a core file removed in Moodle 4.4 (MDL-80409). This plugin requires Moodle 4.1 and so instead can use the replacement introduced in Moodle 3.9, dataformat::download_data().
When a student completed a questionnaire then shown the "Thank you for completing this Questionnaire" page there was a JavaScript error: Uncaught TypeError: formChild is null This was because the JavaScript for the questions form was being inadvertently loaded for the Thank you page where this form is not present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.