Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow optional abs_path and lineno for JsFrame #1581

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
error for invalid abs_path
  • Loading branch information
samuelmaddock committed Jan 9, 2025
commit b381fe373700035de8517da699787b0019b802c0
8 changes: 7 additions & 1 deletion crates/symbolicator-js/src/symbolication.rs
Original file line number Diff line number Diff line change
@@ -115,8 +115,14 @@ async fn symbolicate_js_frame(
}
};

let abs_path = match raw_frame.abs_path {
Some(ref abs_path) => abs_path,
None => {
return Err(JsModuleErrorKind::InvalidAbsPath);
samuelmaddock marked this conversation as resolved.
Show resolved Hide resolved
}
};

let col = raw_frame.colno.unwrap_or_default();
let abs_path = raw_frame.abs_path.clone().unwrap_or_default();

let module = lookup.get_module(&abs_path).await;
samuelmaddock marked this conversation as resolved.
Show resolved Hide resolved

Loading