Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(js/jvm): Emit stacktrace metrics #1559

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Conversation

loewenheim
Copy link
Contributor

We never emitted stacktrace metrics (number of stacktraces/frames per request) for JS¹ and JVM. This adds the most important metrics for those platforms.

¹ Well we did for JS but under a different name.

@loewenheim loewenheim requested review from Swatinem and a team November 28, 2024 10:12
@loewenheim loewenheim self-assigned this Nov 28, 2024
Copy link
Member

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm.

Though I would actually question whether these metrics are at all useful?
What conclusions do we draw from these? I believe the "number of" metrics are just a measure of how complex the events are. Do we even care about that?
The "unsymoblicated" / "missing sourcescontent" is also rather tied to customers misconfiguring their build system, or unsymbolicatable frames for which its not possible to access sourcemaps.

In either case, none of these metrics is anything we can active influence, or a measure of the quality of our service?

@loewenheim
Copy link
Contributor Author

Though I would actually question whether these metrics are at all useful?

Right, fair question. I'm doing this in preparation for having Sentry send us platform values with events and stack frames. This is so that when we (eventually) get mixed stacktraces, we can differentiate the frames (recognizing native frames is easy, they're the only ones with an instruction_addr, but JS and JVM frames can't trivially be told apart).

I want to tag these metrics (specifically the num_frames) with the platforms they have set to see how often we actually have this information and whether e.g. JS events with non-JS platforms make it through.

@loewenheim loewenheim merged commit 25a92eb into master Nov 29, 2024
13 checks passed
@loewenheim loewenheim deleted the feat/js-jvm-metrics branch November 29, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants