Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(trace) match event_id by error #81370

Merged
merged 1 commit into from
Nov 27, 2024
Merged

fix(trace) match event_id by error #81370

merged 1 commit into from
Nov 27, 2024

Conversation

JonasBa
Copy link
Member

@JonasBa JonasBa commented Nov 27, 2024

When linking by eventId, the id can belong to an error that is associated to any node. This PR changes the find functionality so that it also considers events and performance issues associated with any node in the tree.

@JonasBa JonasBa requested a review from a team as a code owner November 27, 2024 17:38
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 27, 2024
Copy link
Contributor

@Abdkhan14 Abdkhan14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@JonasBa JonasBa enabled auto-merge (squash) November 27, 2024 17:40
@JonasBa JonasBa merged commit 4d946ce into master Nov 27, 2024
43 of 44 checks passed
@JonasBa JonasBa deleted the jb/trace/event-matching branch November 27, 2024 17:50
jan-auer added a commit that referenced this pull request Nov 28, 2024
* master: (219 commits)
  fix: flatten searchable os distribution fields (#81297)
  chore(profiling): Remvoe unused profile functions metrics hook (#81396)
  fix(prompts): Properly return false instead of undefined when prompt data is null (#81404)
  fix(insights): broken screen rendering doc link (#81257)
  fix(rpc): Only groupby when needed (#81403)
  feat(grouping): Tally frame types while building exception grouping components (#81341)
  fix(similarity): Limit > 30 system frame check to Java (#81385)
  feat(alerts): Adds EAP spans results consumer configs (#81365)
  ref(insights): simplify domain view header by using tab links (#81324)
  fix(issues): Add projectId for flag onboarding on click (#81387)
  chore(flamegraphs): Remove unused legacy flamegraph code path (#81381)
  fix(performance): No table overflow + glitchy behaviour (#81378)
  feat(widget-builder): Add feature flag for redesign (#81377)
  feat(profiling): Clean up continuous profiling ui and compat flags (#81260)
  feat(visibility): Clamp date range for `TagStore` queries (#81363)
  test(taskbroker): Add CLI command for sending taskbroker tasks (#81319)
  feat(dashboards): Add ff for favouriting dashboards (#81368)
  fix(trace) match event_id by error (#81370)
  fix(insights): add missing slash on performance moving banner (#81364)
  ref(models): Include event id in `Event` repr (#81345)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants